I think would be good to have ability to filter some node types from autocomplete widget.

Patch attached.

CommentFileSizeAuthor
#3 ckeditor_link_2.patch2.42 KBtaran2l
ckeditor_link.patch2.08 KBtaran2l

Comments

anrikun’s picture

anrikun commented
Status: Patch (to be ported) » Needs review

Thank you for the nice contribution.
Let's ask for reviews first :-)

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented

Yes, no problem.

Just missed the status ;-)

taran2l’s picture

taran2l
Primary language Ukrainian
Location Lviv
commented
StatusFileSize
new ckeditor_link_2.patch2.42 KB

I've changed logic for this patch.

As users can create new content types, probably better to include them by default. Also after installation now all content types will be available with autocomplete (as it was in original module).

So now this option logic changed to exclude content types.

Also fixed permissions bug. Forgot to add new permission to hook_perm.

anrikun’s picture

anrikun commented

Thanks!

mstef’s picture

mstef commented
Status: Needs review » Needs work

Definitely think, like most other modules, the checkboxes should be for node to include. Having a new node type automatically exposed could be considered a security issue.

RedRat’s picture

RedRat commented

Agree with mikestefff: module parameters have to include node types, not exclude them. Is there any progress in the this patch integration?

anrikun’s picture

anrikun commented
Version: 6.x-1.2 » 6.x-2.x-dev
Status: Needs work » Fixed

This is now present in the new 6.x-2.x branch.
Please read #1107954: New 6.x-2.x and 7.x-2.x: To developers who want to support CKEditor Link.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.