Port flexifilter to drupal7

Looks awesome to me. If we did it during GHOP we can certainly do the port during GCI with some love and attention from the mentors.

Flexifilter is kind of in disrepair in Drupal 6 as it is. Are we sure it's a good idea to port it to Drupal 7?

what about rewriting flexifilter in d7?

(maybe giving it a better name?)

If dmitri is ready to go on this we may as well right? I'm sure that no matter what he does it's going to turn out awesome so maybe this is a great time to rewrite.

Yes, let's give this one a go. This should definitely be marked as difficult in the GCI system... Marking as RTBC.

This has been moved to GCI. For now I set it to 7 days for the length of time needed- please let me know if it needs more/less time.

Hi all,

I've claimed the task on Melange and I had a quick question about when I'm supposed to use the drupal_* string functions compared to the standard PHP string functions. Coder says that I should replace the standard PHP functions with the drupal_* equivalents in most cases. However, the 6.x branch for flexifield does not use the drupal_* functions even though a.d.o says that the drupal_* functions have been around since 4.7. Should I leave it as-is then?

Work in progress is located here: https://github.com/axyjo/flexifilter-d7

Thanks!

Forgot to change status.

Got my question answered on #drupal-gci by dmitrig01.

Could I get an extension please? I need this weekend to fix one last hook (hook_filter), make it work in sqlite and test it with mysql. I don't have postgres, so I can't test with that. Existing work is available in the github repository mentioned in #9.

With the current git I'm getting this error on admin/structure/flexifilters:
Fatal error: [] operator not supported for strings in /var/www/example.org/htdocs/includes/theme.inc on line 1629

Thanks, I'll look into it.

axyjo, try re-claiming the GCI task

If you use the drupal_* string function make sure flexifilter can still export correct PHP module code.

Sorry about the delay, just finished exams yesterday. Here's the code on GitHub that *should* be ready to go. I've clicked through the admin interfaces and it seems to work, but I'm not sure how to test whether everything works as it should. There's also D7 coding standards changes included in it. Link: https://github.com/axyjo/flexifilter-d7

I've also attached a patch on this comment. This is against the current 6.x version in CVS.

@cor3huis: It seems that the PHP module code is syntactically correct, but I have no idea on how to test it.

I have no idea why the file didn't upload and why the issue got untagged.

Ugh, trying again.
Edit: Finally!

Wow, axyjo, this looks impressive! I'll ask dereine to take a look at it. Thanks for all your hard work!

THX for the reply on http://drupal.org/node/957528#comment-3844280 will test it on D6, I need to fix first other D6 module issues (Mailhandler)

@dereine: Sorry about the debug code. It was part of my uncommitted changes and it got rolled in with the patch. I'll look into drupal_write_record and re-roll shortly (without the debug code).

@cor3huis: This patch converts Flexifilter to D7.

Patch against the github code to move flexifilter to the same modules group as Markdown, SimpleWiki, Textile, and Typogrify.

Added a filter and a chunk-grabber, and got the following notice:

• Notice: Use of undefined constant FLEXIFILTER_MAX_FILTERS - assumed 'FLEXIFILTER_MAX_FILTERS' in flexifilter_filter_edit_form_submit() (line 756 of flexifilter.admin.inc).

The constant doesn't appear to be defined in any of the other source files, either.

sites/all/modules/flexifilter$ grep -ri max .
./flexifilter.module:      $id_next = max($id_next, $row->pid + 1);
./flexifilter.components.inc:      $max          = isset($settings['number']) ? $settings['number'] : '2';
./flexifilter.components.inc:      $max     = count($replace);
./flexifilter.components.inc:        if ($i >= $max) {
./flexifilter.components.inc:          $i = $i - $max;
./flexifilter.components.inc:        '#title' => t('The maximum number of characters to allow in this slice.'),
./flexifilter.admin.inc:      $condition_max_id = 0;
./flexifilter.admin.inc:          $condition_max_id = max($condition_max_id, 1 + (int) substr($key, 10));
./flexifilter.admin.inc:        $form['condition_' . $condition_max_id] = flexifilter_filter_edit_form_condition(flexifilter_filter_edit_form_new_condition_data($data['add_condition']), $show_advanced);
./flexifilter.admin.inc:    '#maxlength' => 127,
./flexifilter.admin.inc:    '#maxlength' => 255,
./flexifilter.admin.inc:    if (flexifilter_get_number_enabled_filters() < FLEXIFILTER_MAX_FILTERS) {

The code context is as follows:

function flexifilter_filter_edit_form_submit($form, &$form_state) {
  $values = $form_state['values'];
  $values['components'] = flexifilter_filter_edit_form_components_from_data($values['components'])\
;
  $values += $values['basic'];
  unset($values['basic']);
  if ($values['fid'] === 'new') {
    $enabled = 0;
    if (flexifilter_get_number_enabled_filters() < FLEXIFILTER_MAX_FILTERS) {
      $enabled = 1;
    }
    $values['enabled'] = $enabled;
  }
  $fid = flexifilter_save_filter($values);
  if ($values['fid'] === 'new') {
    drupal_set_message(t('Flexifilter created.'));
    if ($values['op'] == $values['submit2']) {
      unset($form_state['storage']);
      unset($form_state['rebuild']);
      $form_state['redirect'] = 'admin/structure/flexifilters/' . $fid . '/edit';
    }
  }
  else {
    drupal_set_message(t('Flexifilter saved.'));
  }
  if ($values['op'] == $values['submit1']) {
    unset($form_state['storage']);
    unset($form_state['rebuild']);
    $form_state['redirect'] = 'admin/structure/flexifilters';
  }
}

Dunno... I'm tempted to just comment out the offending code.

Mmm....

Tried adding components multiple times, but the form just kept coming back without any noticeable change.

Finally tried clicking on the [Preview] tab, typed "foo" into the text box, and clicked the (Preview) button. Got the following errors:

• Notice: Undefined index: components in flexifilter_filter_preview_form_submit() (line 1031 of flexifilter.admin.inc).
• Warning: Invalid argument supplied for foreach() in flexifilter_invoke_components() (line 321 of flexifilter.module).
• Notice: Undefined index: components in flexifilter_filter_preview_form_submit() (line 1032 of flexifilter.admin.inc).
• Warning: Invalid argument supplied for foreach() in flexifilter_invoke_components() (line 321 of flexifilter.module).

Gonna give it up. Was hoping to port a couple of customfilters (D6) to flexifilter (D7) but it looks like I'm gonna have to write a custom module or two, instead.

FLEXIFILTERS_MAX_FILTERS was removed. Let me fix up the code and try doing what you did again. I'll also integrate your patch. Thanks for testing!

Noticed the change to use drupal_write_record(). Is it ready for testing again?

There's still an issue with the installation process where some of the values aren't populated correctly in the database. I'll update the issue when I fix this error. Thanks for helping test this!

@pillarsdotnet IMHO helping to get this to work will save you quite some time instead of creating yet another module, but then again, I don't know how fast you can type ;)

Alright, the preview functionality now works in the latest HEAD. The latest HEAD also includes some unit tests. Currently working on the component adding issue.

@cor3huis -- I already created the modules I needed. One of them converts scripture references (e.g. [John 3:16]) to block-formatted quotations from the Bible. The other converts references to node titles (e.g. [About] or [Contact Us]) to node links. Source available on request.

However, I'm still interested in testing and troubleshooting this module, once it's ready.

All done (I think)! Click-testing through the issues reported above works, as well as creating a text format with a flexifilter. Patch against current 6.x HEAD attached, and incremental work can be found on GitHub (http://github.com/axyjo/flexifilter-d7).

Seasons greetings!

A few more fixes based on dereine's comments in IRC.

subscribing

subscribe

subscribe.
What about creating a d7 branch (and d7 -dev version) for this on the module page?

subscribe

subscribe

Any progress on this axygo? I tried to install the Github version but enabling the mediawiki filter gives me errors.

Cheers.

The patch in 35 is the latest version.

Any idea on a time frame for a D7 release?

@majortom, as always, no timeframe. The only way to speed things up is to help out with current flexifilter whereevery you can. Thus walk the issue queue and solve issues you can, comment on issues, provide patches.
You can also contact the module maintainer an ask to become a co maintainrer for the time being. You could use the coder module online http://upgrade.boombatower.com/tools/php/directories to auto convert to a D7 version, fix something and post the alpha version as an issue with review status.

The patch in 35 is ready to go as soon as the maintainer is ready to commit it. It passes basic testing.

@axyjo YEAH! happy happy joy joy!. If I'm done with other Drupal stuff I'm ready to test Flexifilter, and brush-up my RegEx skills in the same run ;). IMHO Flexifilter is awork of art and undervaluated. It would be a candidate module to put in the Spotlight as soon as stable version is available.

subscribe

It is difficult to apply this patch because it was rolled against a drupal.org tarball from the CVS era. There are $Id$ style tags in there, as well as information added by the drupal.org packaging script. If you could reroll this against the git 6.x-1.x branch, that would be a big help. Thanks!

Committed. Thanks everyone!