Download & Extend
Project » Issues

version_patch is being defined for dev releases

Posted by deviantintegral on October 30, 2010 at 6:17pm
Project:Project
Version:6.x-1.x-dev
Component:Releases
Category:bug report
Priority:normal
Assigned:Unassigned
Status:active

Issue Summary

For some reason, the version_patch attribute is being defined for some dev releases. This breaks drush make (#954476: Invalid version errors for non-"recommended" projects), while also not making a lot of sense. For example: http://updates.drupal.org/release-history/nodequeue/7.x

Is this by design, or is it something to be fixed?

Login or register to post comments

Comments

#1

Posted by webernet on October 31, 2010 at 4:24pm

It's set on the node form: http://drupal.org/node/95884 - I tried changing it to blank or x but it didn't stick.

#2

Posted by dww on October 31, 2010 at 8:06pm
Project:Drupal.org infrastructure» Project
Version:<none>» 6.x-1.x-dev
Component:updates.drupal.org» Releases

Not by design, no. Sounds like probably a bug somewhere either in project_release or cvs.module. Oh how I hate you, cvs.module's altering of the release node form...

#3

Posted by lsolesen on November 5, 2010 at 11:01am

I am having problems with media, boxes and context when wanting to install it in Drupal 7.

#4

Posted by milkmiruku on May 12, 2011 at 12:11pm

subscribe

#5

Posted by willmoy on June 5, 2011 at 5:12pm

Sub, just ran into this on nodequeue again

#6

Posted by samhassell on August 5, 2011 at 8:05am

me too with nodequeue

*edit* content_taxonomy as well.

#7

Posted by dww on August 9, 2011 at 10:19pm

These all look like legacy releases:

mysql> SELECT prn.nid, prn.tag, prn.version, prn.version_patch, pp.uri FROM project_release_nodes prn INNER JOIN project_projects pp ON prn.pid = pp.nid WHERE prn.version_patch IS NOT NULL AND prn.rebuild = 1;
+--------+--------------+---------------+---------------+---------------+
| nid    | tag          | version       | version_patch | uri           |
+--------+--------------+---------------+---------------+---------------+
|  94225 | master       | master        |             1 | annotation    |
|  95202 | master       | master        |             1 | og            |
|  95746 | master       | 7.x-1.x-dev   |             1 | forward       |
|  95884 | 7.x-2.x      | 7.x-2.x-dev   |             2 | nodequeue     |
| 377058 | 6.x-1.x      | 6.x-1.x-dev   |             0 | casetracker   |
| 428698 | 6--1-0       | 6.x-1.0-dev   |             0 | regex_filter  |
| 377036 | 6.x-1.x      | 6.x-1.x-dev   |             0 | gamertags     |
| 377016 | 6.x-2.x      | 6.x-2.x-dev   |             0 | ad            |
| 130273 | 4-7--2-0     | 4.7.x-2.0-dev |             0 | MyDrupal      |
| 167599 | 5--1-0-BETA1 | 5.x-1.0-dev   |             0 | dataview      |
| 171325 | 5--1-0       | 5.x-1.0-dev   |             0 | filmforge     |
| 377078 | 6.x-1.x      | 6.x-1.x-dev   |             0 | cache_browser |
+--------+--------------+---------------+---------------+---------------+
12 rows in set (0.41 sec)

A few of these are obviously bogus cruft. Not sure why they weren't hit and cleaned during the Git migration.

However, it's weird that other than nodequeue, none of the other projects in this thread people are complaining about (e.g. content_taxonomy, media, boxes and context) are showing up in the query.

Anyway, I'm prepared to say this is just garbage data from old bugs in code that's no longer used (namely cvs.module). I don't see any harm in trying to fix this brute force with the following query:

UPDATE project_release_nodes SET version_patch = NULL where version_patch IS NOT NULL AND rebuild = 1;

Any objections?
nobody click here