I just updated to the newest skinr dev and now it breaks the panels css.

All other css is fine, but anything panels doesn't show.

Comments

that0n3guy’s picture

This might be because of 2.8 and not because of skinr...

jacine’s picture

Status: Active » Closed (works as designed)

The 2.x-dev version of Skinr supports the latest version of Panels which is 6.x-3.8.

There are significant changes between 2.x and 3.x versions of panels, so it's not possible for us to sanely support anything lower than the current version, especially since it's not supported by Panels either. I'd suggest you upgrade to the new version of panels and make sure you run update.php, as Skinr needs to make database changes to account for the changes in Panels.

that0n3guy’s picture

Title: Newest dev breaks panels css with panels 2.8 » Newest dev breaks panels css with panels 3.8
Status: Closed (works as designed) » Active

My mistake... I meant 3.8.

Ever since I updated to panels 3.8 and the newest skinr.. my panels css basically doesn't show up (all the stuff like float left/right, column widths, etc... is no where to be found in firebug).

If I uninstall skinr, flush my caches, my panels work right. Re-install skinr, flush my caches... panels screws up.

jacine’s picture

Ugh, well that's disappointing.

Every single version of Panels that gets released seems to break Skinr. This will need to be tested, so we can figure out what changed and provide a fix. We'll try to do this tomorrow.

nomonstersinme’s picture

I'm trying to test this out and what happens is that when I select skinr as my style for a pane and then pick a skin and save the panel the skin classes are not applied. However, when I edit the skin settings via the cog on the panel my skinr settings are saved. From there when I am editing the panel and I go to change the skin on a pane my skinr settings save correctly and my classes are shown in the right places.

I also created a new pane in this panel and selected skinr as a style and a skin, on the initial save my skinr classes were not there. Then instead of using the cog (which @moonray informed me bypasses panels) I went back into the panel ui and edited the skin in there. Upon saving that my skinr styles were being shown correctly.

So technically I can't reproduce the error that @that0n3guy is having because I can still use skinr with panels 3.8... but the initial save is a bug.

Unless I am completely missing something here?

that0n3guy’s picture

@nomonstersinme

Did you clear your caches... skinr worked for me w/ 3.8 till I cleared my cached a couple times. Also your issue sounds like something completely different than what I'm experiencing.

I have seen my issue on 2 different sites.

jacine’s picture

Component: Code » Panels
Status: Active » Postponed (maintainer needs more info)

@that0n3guy We are not experiencing problems with the 3.8 version of Panels and it's not entirely clear what is going wrong on your end. Can you give us an export of your Skinr data, and steps to help us try to reproduce? Thanks. :)

vrajak@gmail.com’s picture

I'm not really clear on how to go about reproducing this either, and nomonstersinme seems to have come across a different issue. I've mailed the starter of the issue and asked him to post back as Jacine already did but it's been awhile so thought I should ask again.

that0n3guy’s picture

Well... I cant get it to do it on a new install. But I have several existing sites that do it. Wonder if it has to do w/ an update from panels 3.7 to 3.8... but that doesn't make much sense.

I'll do some more testing and see if I can figure out whats going on.

that0n3guy’s picture

Title: Newest dev breaks panels css with panels 3.8 » Newest dev breaks panels css with panels 3.8 when using Display Suite (ds) module

Well, I cloned the site (oh beautiful aegir how I love you...) and started disabling modules. I found out Display Suite is the culprit.

It also did it on my new site, here is how to reproduce.
- install panels, ctools, skinr, etc...
- create a panel node. flexible, add a region to the left.
- put some custom content in the left and the right.
- add a skinr style to the panes
- enable ds
- flush cache

The panes wont be side by side but on top of each other.

I don't know if this is should be a ds issue though since it didn't happen till I updated panels and skinr.

vrajak@gmail.com’s picture

Thanks for posting back that0n3guy, I'll be going through your steps soon and post back on if I can recreate it.

As for Display Suite (http://drupal.org/project/ds) being an issue I can't say yet, but will try and see. Do you have any particular custom setup or additional modules you are using with DS?

that0n3guy’s picture

I have other modules installed, but just enabling ds on my new install killed panels css. It should do the same for you.

chrisschaub’s picture

We were seeing panes styled with skinr were disappearing with the latest panels/ctools. Clear cache, they come back. We're not using skinr now and the panes have not disappeared. I think there might be a skinr / panels caching issue.

bkosborne’s picture

http://drupal.org/node/979912

This is the issue schaub123 was talking about. Once I updated Skinr last night to the latest stable, my panel displayed nothing. I had also updated Panels and CTools. I reverted those two and it did not fix, so I reverted Skinr and it did fix.

pdbob’s picture

I imagine that this is related... here is the error that I am getting

"Panels operating in Legacy mode
Panels is operating in Legacy mode due to the following issues:
Panels 3.6 made changes to the rendering order in a way that affects certain style plugins. The above modules implement style plugins, but have not indicated their compatibility with this new system. See http://drupal.org/node/###FIXME for information on how to update style plugins to the new system.
skinr - Style plugins"

I don't have any idea what I was supposed to see here http://drupal.org/node/###FIXME

Thanks

Update**** I just navigated back to the status report and the error is gone. Thanks again

*****Re-Update, the same issue just reappeared, still an issue. And again, Thank you

chrisschaub’s picture

I have not seen this problem with panel nodes so far, only panel pages. Is the caching mechanism different? This all seems to be cache related.

pdbob’s picture

Yes, it was a cache issue, thanks

chrisschaub’s picture

Be warned that clearing cache will only temporarily fix though, it will come back.

vrajak@gmail.com’s picture

Tried recreating this issue as per comment #10, but was unsuccessful. I did not try a new install, I tried this on my ongoing local Skinr 6.x-2.x-dev site. So I think I should give that a shot. Its possible I might have a different version of some module that is breaking it, but can't say as I'm only so knowledgeable.

That being said there seems to be variations of the issue going on here as far as I understand.

- that0n3guy has the problem with panel nodes, reports possibly it may be the DS module's fault.

- schaub123 has the problem with panel pages, but NOT panel nodes. Reports most likely Skinr's fault.

- bkosborne mentions reverting skinr updates restores his panels. But are you using DS module also?

- pdbod is having a possible related issue, but I don't know what steps he took to get those error messages. (pdbod can you please post? thanks) And it seems to be coming and going, so a cache issue.

Will have to be looked at further as I don't know what a clear solution/cause is yet.

bkosborne’s picture

I am not using DS at all. Also, flushing the cache using devel did not work for me, it's actually what caused the problem. It was a panel that was my homepage. Did all upgrades, looked fine... flushed cache.... gone. Went into site info and changed my homepage to something else, then back again, and it was back. flushed cache, gone again.

pdbob’s picture

All I was doing was installing a fresh site and enabling some modules, I haven't even loaded any content. I just went to check and the error was there again, cleared cash and it was gone. I haven't done anything with this site yet other than getting it ready to work on.

that0n3guy’s picture

Just an FYI, this happens on both panel nodes and panel pages (like node template). Also happens on every site I have with DS.

AND there is no error shown, just stops loading css correctly.

chrisschaub’s picture

I wonder. I've seen the "views" disappear within the panel, but not the "custom content" text -- that always stays. So, maybe it's an issue with views caching and panels? I'm assuming most folks are using some sort of views on these panels. If they are all views based, then it would appear empty.

vrajak@gmail.com’s picture

Title: Newest dev breaks panels css with panels 3.8 when using Display Suite (ds) module » Newest dev breaks panels css with panels 3.8 - Possible caching problem
vrajak@gmail.com’s picture

Title: Newest dev breaks panels css with panels 3.8 - Possible caching problem » Skinr update (dev or stable) breaks panels css with panels 3.8 - Possible caching problem
yosisays’s picture

any updates on this issue. I have all the latest versions of panels,ctools, and skinr and still gettting this issue. no panels are showing up.

yosisays’s picture

is this still an issue with panels 6.x-3.10?

astonvictor’s picture

Issue summary: View changes
Status: Postponed (maintainer needs more info) » Closed (outdated)

D6 reached its EOL back in February 2016, and there is no active release for D6 for this module anymore.
Development or support is not planned for D6. All D6-related issues are marked as outdated in a bunch.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.