Currently all the settings for forward are in one admin page. This is not so great when you have multiple developers working on a site and they need to change the HTML / text for the thank you, but you don't want them mucking around with your flood control or the email address that it gets sent from.

There are permissions for override flood control and override email address, but it doesn't look like they actually *do* anything. It seems like it would make more sense to remove those 2 permissions in favor of 2 more general permissions.. one for admin settings, one for the html portions of emails/replies.

CommentFileSizeAuthor
#3 forward-permissions-breakout-965564-2.patch4.97 KBrfelsburg
#1 forward-permissions-breakout-965564-1.patch5.26 KBrfelsburg

Comments

rfelsburg’s picture

rfelsburg commented
Assigned: Unassigned » rfelsburg
Status: Active » Needs review
StatusFileSize
new forward-permissions-breakout-965564-1.patch5.26 KB

Broke out permissions for admin settings, versus email settings.

I also changed permission names to reflect what they actually do. Such that people can recognize that 'access forward admin pages' means allowing access to the forward module in the admin menu, versus 'forward admin settings' which actually gives permissions to change the admin settings.

Currently the forward admin menu populates two hardcoded menu options for 'Admin settings' and 'Email settings'. I'm working towards making this more dynamic like the 'Logging and Alerts' admin menu, which uses menu_get_item and a series of sql queries to populate a block.

rfelsburg’s picture

rfelsburg commented
Assigned: rfelsburg » Unassigned

Updated Assigned: unassigned

rfelsburg’s picture

rfelsburg commented
StatusFileSize
new forward-permissions-breakout-965564-2.patch4.97 KB

Fixed the display menu to dynamically output the sub pages of the forward module. At this point 'Admin Settings' and 'Email Settings'. Both dynamically generated off of the plid for the forward module.

This patch is a replacement. This is not a patch to the initial patch.

crimsondryad’s picture

crimsondryad commented

This patch works for me.

randompants’s picture

randompants commented

I've tested it and it works for me. Nice job!

crimsondryad’s picture

crimsondryad commented
Status: Needs review » Reviewed & tested by the community

Marking RBTC

john.oltman’s picture

john.oltman commented
Issue summary: View changes
Status: Reviewed & tested by the community » Closed (outdated)