Hey all (maintainers),

I just wanted to propose bringing in eojthebrave's excellent ooyala_markers module he created.
https://github.com/Lullabot/ooyala_markers

From the README:

This module implements a new CCK field type which when added to a content type in conjunction with an ooyala video field provided by ooyala.module allows you to specify chapter titles/times. When displayed user's can click the chapter title and the Ooyala player will jump to the chapter time.

There are bugs in Ooyala module that should be worked out before including this with the package.

See: http://drupal.org/node/908162 and http://drupal.org/node/908176

As you can see, the bugs he mentions are worked out and I think this is some great functionality.

CommentFileSizeAuthor
#4 ooyala_markers.patch12.27 KBquicksketch

Comments

quicksketch’s picture

quicksketch
he/him
commented

This looks like great functionality to add to the Ooyala project. The code looks pretty good, (certainly good enough for an initial commit), but I think it'd make sense to make an "Ooyala" package section on the modules page if we're going to start bundling multiple modules in the Ooyala project. Especially considering potential future enhancements that will likely be in separate modules too, like the "Ooyala channels" module we may eventually put together for creating channels.

eojthebrave’s picture

eojthebrave
he/him
Primary language English
Location Minneapolis, MN
commented

FYI, I haven't actually tested this against ooyala.module in CVS yet. This was written against my mega-hacked version of the module since I couldn't wait for all the patches that this required to go in. Those patches are all in now, and this should work no problem. I would like to test it with ooyala.module from CVS before it gets committed though just as a sanity check.

I should be able to do so in the next day or two.

sirkitree’s picture

sirkitree commented
Status: Active » Needs work

Ok, I can certainly see the benefits of that. Marking as needs work then.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Fixed
StatusFileSize
new ooyala_markers.patch12.27 KB

I've made a few minor revisions to the code including:

- Missing semi-colons in the JS file.
- Changing the package name.
- Moving the README.txt information into the Ooyala module README.txt, so that way people have a single location for reading about the bundled modules.

I tested all the code and functionality and it works fantastic. Great work guys!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.