Posted by skwashd on November 10, 2010 at 5:31am
4 followers
| Project: | Wysiwyg |
| Version: | 7.x-2.x-dev |
| Component: | User interface |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
| Issue tags: | Usability |
Issue Summary
When configuring WYSIWYG profiles (/admin/config/content/wysiwyg/profile/[name]/edit) with IMCE WYSIWYG bridge enabled the IMCE label in the Buttons and plugins section is a link to http://drupal.org/project/imce
This is poor usability because it makes the label useless. The common user expectation is that clicking the label would check the checkbox, in this case the user is taken to drupal.org without any warning. The user is likely to be well aware of what IMCE is given that they have installed it already.
Comments
#1
The attached patch fixes this in 7.x-1.x-dev using current CVS.
#2
Needs to be fixed in Wysiwyg instead.
#3
I don't see why this needs to be fixed in WYSIWYG, the issue is with how the bridge prepares its label.
The attached patch deals with the problem in the bridge.
#4
The patch does not fix the usability problem you mention, it only avoids it by removing the URL stating where the plugin originates from. That information should still be there so Wysiwyg can inform users of this. A better approach would be patching Wysiwyg to not turn the labels into links - which is done for any plugin wrapper providing an URL - and show the link somewhere else.
#5
The attached patch moves the fix into WYSIWYG. When the URL is specified it will display "Visit project page." as the #description for the checkbox. I have only tested it with IMCE and couldn't find any WYSIWYG button plugins for D7.
Unlike the the existing code, this version opens the link in a new window. I am not sure this is the best idea, but it keeps the intention of the existing code.
#6
I tried to re-roll this patch but ran into a problem.
I saw no effect from the #description attribute you are adding.
To get a similar result I now append a link to the #title attribute.
This results in something like: [] IMCE (project page)