We are missing an API function to remove a string translation given the context and the translation language.

CommentFileSizeAuthor
#1 i18nstrings-967688-1.patch962 bytesplach

Comments

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Status: Active » Needs review
StatusFileSize
new i18nstrings-967688-1.patch962 bytes
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Assigned: Unassigned » miro_dietiker

subscribe on request.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

@miro_dietiker:

Any chance for this? It should be really straightforward...

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

I think this is pretty fine. Agree this operation is a missing API.

Since we don't have a UI that allows deletes, you might define this function also in your custom application.
I think i18n has not implemented a full-feature API, but only implemented what was needed and used...
If we want to make it a CRUD+ full featured API layer, i suspect there are also other functions missing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

@miro_dietiker:

Since we don't have a UI that allows deletes, you might define this function also in your custom application.

Well, I'd "steal" the namespace, which I'd like to avoid, moreover someone else might need it.

If we want to make it a CRUD+ full featured API layer, i suspect there are also other functions missing.

I did not make a complete check but IIRC when I rolled the patch I found that deletion was the only CRUD operation missing.

jose reyero’s picture

jose reyero commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

Looks like something good for D7, but really we don't want to be adding features for the D6 version at this stage.

jose reyero’s picture

jose reyero commented
Status: Reviewed & tested by the community » Active

I think we better don't add APIs for the sake of having more APIs. We need some purpose for them.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Well, in i18nmenu_node I need this function to remove a menu item translation when the corresponding node is deleted.

See #910974: Menu title translation not removed on node deletion.

jose reyero’s picture

jose reyero commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Status: Active » Reviewed & tested by the community

Ok, let's get it into 6.x version

Then let's move it to 7.x

@plach,
You can commit it.

Btw, I had forgotten that module. W need to take a look at it to see how it can work with the new menu translation in 7.x. Now we have some menu language and per menu options maybe we could get that into i18n_menu.

See also #1078908: Error on menu item translate

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Active

Commited to to 6.x-1.x.

Btw, I had forgotten that module. W need to take a look at it to see how it can work with the new menu translation in 7.x. Now we have some menu language and per menu options maybe we could get that into i18n_menu.

No problem, updated #386372-56: Localize menu items by node translation set accordingly.

However I'd wish to release the 6.x-1.0 version first, is i18n 6.x-1.9 coming soon?

jose reyero’s picture

jose reyero commented

> However I'd wish to release the 6.x-1.0 version first, is i18n 6.x-1.9 coming soon?
As soon as we have some good reason to do it :-)

So if you need one, next weekend is ok?

(Then let's say 3 days if you guys want to commit any other minor fix, that I will, then rest of the week for testing?)

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

The next weekend sounds good to me. For what i18nmenu_node is concerned there is no additional commit needed on i18n.

I have just a followup patch pending (#910974-4: Menu title translation not removed on node deletion) unless some critical bug comes out in the next days, which is unlikely.

jose reyero’s picture

jose reyero commented
Status: Active » Fixed

I didn't have time for that other bug fixes, but anyway, new release out: 6.x-1.9

Thanks

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Great, i18nmenu_node 1.0 is out!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.