Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.When testing the new Userpoints view transaction page, I noticed that the description and operation supplied by this module need to be updated as follows:
1. In the 'reason' field, the reason is not being linked to the actual node that the user gained access to.
2. In the description, the format currently is: 'User bought access to %title". Should we change this to be consistent with the UP-NC language? (For instance, we never include words like "User". And maybe we don't want "bought" used as the terminology? How about:
"Traded !points to access %title."
Other options:
"Granted access to %title."
"Got access to %title."
"Bought access to %title."
3. The operation is listed as "Substract". (It is spelled wrong and capitalized.) Perhaps it should be the module supplied machine name like we do for UP-NC (for UP-NC we use "userpoints_nc_node_insert").
4. For a transaction supplied by this module, the auto generated description is being incorrectly listed as the "Description (manually entered)" on the points transaction page. And the operation is being incorrectly listed as the "Description (auto generated)". It appears the root of this problem is that the module is filling in the manual description field. This prevents our new description precedence system from working properly (as changing the description field will completely delete the automatically generated description).
--Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | operation2.patch | 1.79 KB | berdir |
| #1 | operation.patch | 1.7 KB | berdir |
Comments
Comment #1
berdirThe patch should fix points 1-4 :)
Currently uses "Gained access to %title", what do you think about that?
Note that existing data isn't touched, that will stay how it is, but nobody seems to use this module currently (in the 7.x version).
Comment #2
BenK commentedHey Berdir,
I tested the latest patch and can confirm that 3. and 4. are fixed. Here are the issues I am having with 1. and 2.:
1. The 'reason' field still isn't being linked to the node that the user gained access to. This might be caused by 2. below.
2. I like your suggestion of "Gained access to %title". However, the auto-generated description is currently displaying as "Gained access to content." The word content is always being used regardless of the node title.
New: 3. I noticed the following error before I applied the patch. If a node title has an apostrophe in it (or possibly a quote mark), it is displaying like this: "User bought access to Ben's Article" In this case, the node title is supposed to be "Ben's Article". So it may be that single and double quotes are not being escaped properly. Since the node title is being replaced with "content" when the patch is applied, I can't test whether this error still happens after the patch. But unless you fixed it, it is likely the bug still exists.
--Ben
Comment #3
berdirUps, should be better now :)
Again, only for new records...
Comment #4
BenK commentedBerdir,
I tried the latest patch and it's working great. Everything is fixed. This is RTBC. :-)
--Ben
Comment #5
berdirCommited.