Currently, the “view all releases” and “add new release” links are somewhere inside the project node. But actually, these functions are local tasks and could be moved to the local tasks section to remove some clutter from the project node. I suggest doing that and renaming “view” to “Description”, “view all releases” to “Releases” “add new release” to “Create release”.

CommentFileSizeAuthor
#3 project_edit_subtabs.patch.txt14.69 KBdww
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dww’s picture

Status: Active » Closed (won't fix)

wow, took me 3 times to figure out what you're talking about: making these things new tabs on the node, instead of links. ;) i don't think i like this proposal for a few reasons:

  1. for end users, a single link to the "view all releases" page is hardly clutter, and in fact, i'd rather see a better UI for listing releases on the project nodes anyway (#89539: table of downloads on the project node, not just a "default release" link)
  2. in terms of the "add new release" link: for project admins (the only people who see this link), there are already a lot of tabs to worry about (view, edit, cvs access, etc) for site admins, it's even worse (outline, revisions, track, etc). another tab for "create release" seems like the clutter IMHO...
  3. furthermore, "add new release" is a node add page. it lives at the path /node/add/project_release/[project_id] so we can't make it a subtab of /node/[project_id]. instead, we'd have to register our own /node/[project_id]/add-release menu, and manually invoke node_add(), etc, etc. no thanks. ;)

anyway, i see this request as a) a lot of work b) partially duplicate with other UI changes that would be (IMHO) more valuable, and c) not much pay off. therefore, "won't fix". if someone wants to provide a patch and set it to "needs review" i'll reconsider. ;)

dww’s picture

Title: Make common project node actions node tasks » make better use of tabs and subtabs on project nodes
Assigned: Unassigned » dww
Status: Closed (won't fix) » Active

ok, after messing with http://drupal.org/node/89538 and http://drupal.org/node/89539 long enough, it's clear that we're going to need to make better use of tabs and subtabs on project nodes to keep everything sane. ;) after a long and fruitful discussion in IRC with webchick, we converged on the following:

  • the project edit tab is going to be split into 3 subtabs: "project" "releases" "issues" (or something).
  • we're going to add a "releases" tab on the project node (visible to all users). this will currently just be the "all releases" list, but in the near future, there will be subtabs for "summary", "date", etc, as we add other views of the releases...

my first priority is actually the subtabs for the edit page, since that's blocking http://drupal.org/node/89538, which is really a bug fix, not just a new feature...

dww’s picture

Status: Active » Needs review
FileSize
14.69 KB

here's a patch against project, project_release and project_issue to reorganized the project node's edit tab. not only will this be (IMHO) much easier for people to deal with that the giant page and all the collapsible fieldsets, it'll allow me to do FAPI theme tricks to get the UI right for http://drupal.org/node/89538, without messing with the entire project edit form. ;)

dww’s picture

FYI: i installed this patch on scratch.drupal.org if anyone wants to see it in action. just check out a project you maintain on d.o and see how the edit tab now looks.

Kjartan’s picture

Status: Needs review » Reviewed & tested by the community

Makes the edit tab a lot less scary as stuff is split up. People will learn to find stuff in the subtabs over time.

dww’s picture

Status: Reviewed & tested by the community » Active

thanks, kjartan. committed to DRUPAL-4-7--2. moving back to active since this issue is also about converting the "view all releases" link into a "releases" tab (which would then have subtabs for the various ways to view your old releases... the current giant listing by date, the nice summary table merlinofchaos and i are working on via http://drupal.org/node/89539, etc, etc).

drumm’s picture

Issue summary: View changes
Status: Active » Closed (works as designed)

I think having the link in context with releases makes sense.