Like this issue has this breadcrumb:

Home » Project » Category » Module » issues

Would be nice if there's similar on comment/follow-up form too.

Putting in a patch.

This makes the breadcrumb on follow up form as:

Home » Project » Category » Module » issues » Issue name

Comments

ChrisKennedy’s picture

Agreed - you might as well capitalize "issues" while you're at it.

Gurpartap Singh’s picture

StatusFileSize
new1.02 KB

Thanks, capitalized it. Someone please review code, seems RTBC to me.

Gurpartap Singh’s picture

Status: Needs review » Reviewed & tested by the community
dww’s picture

Status: Reviewed & tested by the community » Needs work

i know other parts of the code do this, but we shouldn't be using taxonomy_node_get_terms(). we should use $node->taxonomy instead.

thanks,
-derek

dww’s picture

also, the breadcrumb (using your patch, not $project->taxonomy) includes the wrong taxonomy term in the breadcrumb. on a test site, i'm seeing:

Home » projects » Event management » signup » Issues » test issue for breadcrumb

when i should be seeing:

Home » projects » Modules » signup » Issues » test issue for breadcrumb

or perhaps:

Home » projects » Modules » Event management » signup » Issues » test issue for breadcrumb

(though the last 1 is tricky, since module can belong to more than 1 category).
i think you probably want to be using project_project_set_location() if it's available.

thanks,
-derek

Gurpartap Singh’s picture

About the breadcrumbs, check how this issue's breadcrumb is formatted. Or we need to change these mostwhere.

dww’s picture

yes, breadcrumbs are very broken throughout project*.module.
in particular:

http://drupal.org/node/58630
http://drupal.org/node/76030

there are probably others...
if you want to work on consistent, accurate breadcrumbs for all of project*, that'd be fantastic. ;)

thanks,
-derek

Gurpartap Singh’s picture

Assigned: Unassigned » Gurpartap Singh

Will take this up :). Though won't be quick with patches, lots other jobs simultaneously.

aclight’s picture

Version: 4.7.x-2.0 » 5.x-2.x-dev
Status: Needs work » Needs review
StatusFileSize
new934 bytes

Attached is a patch that fixes the breadcrumb when you click follow up on an issue. The new breadcrumb would look like this:

Home » projects » Modules » signup » Issues » test issue for breadcrumb

AC

dww’s picture

Status: Needs review » Fixed

Thanks, aclight. Reviewed, tested, and committed to HEAD, DRUPAL-4-7--2 and DRUPAL-4-7. Please assign this ticket to yourself for posterity. ;)

Cheers,
-Derek

aclight’s picture

Assigned: Gurpartap Singh » aclight

assigning to myself for posterity's sake, as dww suggested :)

Anonymous’s picture

Status: Fixed » Closed (fixed)