Closed (fixed)
Project:
Project issue tracking
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
12 Nov 2006 at 20:30 UTC
Updated:
24 Jul 2007 at 11:16 UTC
Jump to comment: Most recent file
Comments
Comment #1
ChrisKennedy commentedAgreed - you might as well capitalize "issues" while you're at it.
Comment #2
Gurpartap Singh commentedThanks, capitalized it. Someone please review code, seems RTBC to me.
Comment #3
Gurpartap Singh commentedComment #4
dwwi know other parts of the code do this, but we shouldn't be using
taxonomy_node_get_terms(). we should use$node->taxonomyinstead.thanks,
-derek
Comment #5
dwwalso, the breadcrumb (using your patch, not $project->taxonomy) includes the wrong taxonomy term in the breadcrumb. on a test site, i'm seeing:
when i should be seeing:
or perhaps:
(though the last 1 is tricky, since module can belong to more than 1 category).
i think you probably want to be using
project_project_set_location()if it's available.thanks,
-derek
Comment #6
Gurpartap Singh commentedAbout the breadcrumbs, check how this issue's breadcrumb is formatted. Or we need to change these mostwhere.
Comment #7
dwwyes, breadcrumbs are very broken throughout project*.module.
in particular:
http://drupal.org/node/58630
http://drupal.org/node/76030
there are probably others...
if you want to work on consistent, accurate breadcrumbs for all of project*, that'd be fantastic. ;)
thanks,
-derek
Comment #8
Gurpartap Singh commentedWill take this up :). Though won't be quick with patches, lots other jobs simultaneously.
Comment #9
aclight commentedAttached is a patch that fixes the breadcrumb when you click follow up on an issue. The new breadcrumb would look like this:
AC
Comment #10
dwwThanks, aclight. Reviewed, tested, and committed to HEAD, DRUPAL-4-7--2 and DRUPAL-4-7. Please assign this ticket to yourself for posterity. ;)
Cheers,
-Derek
Comment #11
aclight commentedassigning to myself for posterity's sake, as dww suggested :)
Comment #12
(not verified) commented