Hello,

I ran into a few problems with the forward module while trying to implement it on my site and I thought I'd share how I fixed them.

1. One of my clients uses Windows-based hosting where clean urls are not available. It appears that the forward module assumes that clean urls are being used. My patch adds some code to check for clean urls and modifies the links appropriately.

2. I couldn't get the form-type "form" to display on any of my pages. I tracked the bug down to the fact that the variable_get('forward_display_'. $node->type, '0') variable wasn't being set in the variables table unless the content-type was actually updated from the admin/settings area. So, I modified the default value of the variable to "1" so that the form is displayed by default. I think a more correct way of fixing this would be to modify the install file, but I'm not 100% sure.

3. My installations are also using the SMTP module, and I found that the messages weren't being sent in HTML. I tracked the bug down to a lowercase "t" in "Content-type" - the SMTP module was looking for an uppercase "T". Anyway, my change capitalizes the "t" in the forward module (for the record, I also modified the SMTP module so that it wasn't case-dependent.

Hope this helps someone else.

-mike

CommentFileSizeAuthor
forward.patch_4.txt2.07 KBultimike

Comments

seanr’s picture

Status: Active » Fixed

2 and 3 should be fixed, at least in 5.x+. 4.7 version is no longer being maintained except for critical bugs and security issues. Please re-open if the clean URL problem still exists in the 5.x or 6.x versions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

timdiacon’s picture

Version: 4.7.x-1.x-dev » 6.x-1.6
Status: Closed (fixed) » Active

I'm having problems with non clean URLs in drupal 6. If I call the following URL

mysite/forward?path=my_page?variable=some_value

The link on the actual forward page (in the source code) becomes

mysite/forward?path=my_page%3Fvariable%3Dsome_value

This then causes the module to fail when you hit send message as you get a "Page not Found Error"

seanr’s picture

Status: Active » Postponed (maintainer needs more info)

I am unable to reproduce this. Can you give me more information, and possibly an example site to look at? Also, I'd highly recommend you upgrade to the current version (6.x-1.16) or the 6.x-dev version.

BTW, this probably should have been a new issue rather than re-opening an ancient one - they aren't really related.

john.oltman’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
john.oltman’s picture

The non-clean URLs problem, or one of the others...please specify and I'll reopen and retitle the issue

john.oltman’s picture

Title: non-clean urls, default form type settings, integration with STMP module » Links not working with non-clean urls
Version: 6.x-1.6 » 6.x-1.21
Status: Closed (cannot reproduce) » Active
john.oltman’s picture

Status: Active » Closed (cannot reproduce)