Custom Slogan

Hello, and thank you for applying for a CVS account.

As per requirements, the motivation needs to include a description of the module features (more than two sentences), and a comparison with the existing solutions.

Just to provide some additional feedback you're going to need to address after providing a better description and comparison:

• Your code does not conform to the Drupal Coding Standards. You can use the Coder module to get some help in auditing your code. (already mentioned in IRC)
• It's not clear what custom_slogan-admin-settings-form.tpl.php is for: it's not a template file (which is what .tpl.php files are for), and it's not the proper way to declare a form. It also seems to be duplicating custom_slogan_admin_settings(). (already mentioned in IRC)
• You use a mixture of persistent variables and schema to store the data your module provides. Is it possible to combine the storage and use one method?

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.

I found a couple of major things that prevented the module from working correctly:

1. I get errors when enabling the module because of "name = Custom Slogan" in custom_slogan.info. It should be name = Custom slogan without the quotes.
2. I get the following PHP notice on every page:
   Notice: Array to string conversion in token_replace_multiple() (line 278 of /home/dave/Dropbox/Projects/drupal6dev/sites/all/modules/token/token.module).. This is because token.module already defines a global token of [site-slogan]. When you add your own token with the same exact name, it makes an array value of the replacement token rather than a string. So you'll need to change your module's token name.
3. On install, it seems that the module makes the site's slogan set from admin/settings/site-information disappear. Maybe custom_slogan_preprocess_page() should check if custom_slogan_page_get_slogan() returns empty output, or variable_get('custom_slogan_default', '') should be variable_get('custom_slogan_default', '[site-slogan]') as that would use Token.module's site default slogan value, so that nothing would actually 'change' on install. The same goes for the custom_slogan_front variable - should likely default to [site-slogan].
4. The settings form at admin/content/custom_slogan has no 'submit' button for me to save the settings. I would assume you'd want to be using system_settings_form() there.
5. There were lots of coding style issues, but nothing that really prevented me from understanding what was going on. Please make sure to always run your code through Coder module as using the standards helps other developers easily read your code and create patches for you.

Also I just realized the settings form at admin/content/custom_slogan has no 'submit' button for me to save the settings. :)

Edit: incorporated feedback into above comment.

Thanks for your contribution, vidhatanand! Welcome to the community of project contributors on drupal.org.

I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I can understand that the process feels horrible, especially since you've been in it for 40 weeks. Just one note that beejeebus pointed out whitespace issues over a month before your most recent comment and you failed to fix them. #1268154: remove trailing whitespace.