There's a small bug that seems to be fixed by:

http://pages.uoregon.edu/vid/2010/02/01/drupal-gcal-events-module-hack-a...

Essentially links to the specific events don't work because the eid= is converted to eid%d in the link URL. Hope this helps! It's a great little module.

@@ -648,42 +659,46 @@
-            'link' => $item->get_link()
+            'link' => rawurldecode($item->get_link()) /*+ this decodes the event url so it lands on the right page on google*/

-     if (!$item['allday']) {
+        if(strtotime($gcal_date) > strtotime(date('d-m-Y',strtotime('yesterday')))){ /*+ this ensures that only events newer than yesterday are displayed*/
+     if (!$item['allday']) {

@@ -737,22 +752,23 @@
+        }/*+*///end if(strtotime($gcal_date) > strtotime(date(,strtotime('yesterday'))){
CommentFileSizeAuthor
#5 gcal_events.module_6x14-keep_url_vars_and_link_to_events-983994-5.patch2.39 KB_vid
#3 gcal_events.module_6x14-keep_url_vars_and_link_to_events-983994-3.patch1.67 KB_vid

Comments

_vid’s picture

_vid commented

Thanks @CheezitMan.
I had posted that diff report on the gCal Events discussion page last Feb but all comments were removed from that page shortly after that. I was too new to Drupal at the time to realize I should post it as an issue.

Vid

syaman’s picture

syaman commented

Thank you CheezItMan. Your post has helped tremendously in helping to address some gripes I had with this module.

_vid’s picture

_vid commented
Status: Active » Needs review
StatusFileSize
new gcal_events.module_6x14-keep_url_vars_and_link_to_events-983994-3.patch1.67 KB

OK, here's the patch file for this issue.
Patched against 6.x-1.4.
I haven't looked at the latest dev version. Perhaps it's resolved there, but folks continue to ask for this so I thought a 6.x-1.4 patch was in order.

_vid’s picture

_vid commented

I realize that my patch solves the problems that come with simplePIE 1.2.1-dev. It's not applicable to the recommended version: 1.1.3.
For my purposes 1.1.3 wasn't working so I decided to try the latest version available at that time. So this is a pretty specific fix.

_vid’s picture

_vid commented
StatusFileSize
new gcal_events.module_6x14-keep_url_vars_and_link_to_events-983994-5.patch2.39 KB

I've updated the patch to improve the work-around for the lack of 'future events' support while respecting the number of events to be displayed. Basically, I'm moved the $num_events decrement statement inside the if statement outlined above.

This has been tested with and intended to work with simplePIE 1.2.1-dev. So the changes may not be relevant to everyone but now it works as intended for me and a few other people.

jdwfly’s picture

jdwfly commented

WIll check out soon.

jdwfly’s picture

jdwfly commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)