Use signup_status for placeholder signups

Scratching my own itch, I create the attached support module uc_signup_status and modified uc_signup with the following.

I added the following code to function uc_signup_settings_form

  $form['uc_signup_use_placeholders'] = array(
    '#type' => 'checkbox',
    '#title' => t('Set up placeholders when new signups are created'),
    '#description' => t("When enabled placeholders are used instead of the actual sign up data."),
    '#default_value' => variable_get('uc_signup_use_placeholders', 1),
  );

I added the following function to enter the signup regularly and input the info into uc_signup_log for further processing

/*
 * CUSTOM FUNCTION
 * Create a regular signup for a user.
 */
function uc_signup_create_regular_signup($nid, $uid, $oid) {
  $signup_form = array(
    'uid' => $uid,
    'nid' => $nid,
  );
  $sid = signup_sign_up_user($signup_form, TRUE);
  if (is_numeric($sid)) {
    db_query("INSERT INTO {uc_signup_log} (oid, sid, type, uid) VALUES (%d, %d, %d, %d)", $oid, $sid, 1, $uid);
  }
}

And added the following to the end of function uc_signup_order to replace

           foreach ($uids as $key => $uid) {  // CUSTOM CONDITIONAL PROCESSING
            uc_signup_create_placeholder_signup($nid, $uid, $arg1->order_id);

with

          foreach ($uids as $key => $uid) {  // CUSTOM CONDITIONAL PROCESSING
            if (variable_get(uc_signup_use_placeholders, 1)) {
            	uc_signup_create_placeholder_signup($nid, $uid, $arg1->order_id);
            }
            else {
            	uc_signup_create_regular_signup($nid, $uid, $arg1->order_id);
            }
          }

This allows me to turn off the placeholder processing and instead use signup_status

The attached module adds a ubercart conditional action to modify the signup status which I added to predicate "Update order status on full payment" which allowed me to change the signup status from "registered" to "confirmed".

If folks find this useful, maybe the modifications can be added to uc_signup and the attached can act as an optional support module or something.

Here is a patch I created for uc_signup.module using diff.