Order Never changes.
sgriffin - November 20, 2006 - 02:16
| Project: | nodeorder |
| Version: | 4.7.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
Drag Drop works, move up down reports no errors, but actual order doesn't change.
After checking Enable order on category results in this error
* warning: implode() [function.implode]: Bad arguments. in /home/****/public_html/beta/modules/nodeorder/nodeorder.module on line 59.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: UPDATE term_node SET weight_in_tid = nid WHERE weight_in_tid = 0 AND tid IN () in /home/*****/public_html/beta/includes/database.mysql.inc on line 121.
#1
Hmmm, I can see in the code why that would happen... If there are no terms in the vocabulary when you switch the vocabulary to Orderable, then you'll see this message. That's bad, but maybe you can work around it for now...
Can you get it to work by adding some terms to the vocabulary and then turning the Orderable flag off and then back on?
#2
I'm pretty sure there were some already but many not. It appears to be working now.
What about the number of items when you Set the order? You can't use this when you have more than 10 items..
Meaning when you click on the 12th item, it brings up only a page with the first 10, and the 12th is no longer accessible.
It would be nice to either use the Number of posts on page variable, or just show them all which is better since 30 is max.
#3
In addition if you use move up move down on the second page, it jumps back to the first page when you've completed the operation.
#4
The ajax ordering limit of 10 was (Not fixed but worked-around) by using the pager which was previously set at the highest level of 30.
New Line 201
$result = taxonomy_select_nodes(array($tid), 'and', 0, TRUE, $order);
#5
I just checked in a bug fix for this problem, and also for the problem where it appeared that a node couldn't be ordered differently in multiple categories.
To test that things are working correctly, first make sure that all nid/tid/weight_in_tid data is saved correctly in the term_node table. For any tids that are in Orderable vocabularies, the weight_in_tid should be non-zero. You can fix things by turning the Orderable flag off on your vocabularies and saving them. Then, turn the Orderable flag back on.
I would like to keep this issue here only for the "Order Never Changes" problem. I will open a separate issue for the pager bug.
#6
I'm experiencing this issue where if I drag an item and drop it into place, the weight doesnt change. I've verified the weight in term_node and it hasnt changed. The weight is still set to the same thing as the nid value. The front-end works fine graphically. It's just the weight that doesnt change.
Ideas?
#7
I just checked in yet another bug fix that should clear this up. After installing the latest, you will probably need to remove the Orderable flag from any Vocabularies that have it set, and then re-set the Orderable flag. This will clear out the faulty ordering that had already been done (or not done). Let me know how it goes. Things are quite a bit more stable at this point.
#8
hmmm.. just installed your new version.. didn't seem to do anything in Firefox. And in IE6, drag and drop doesnt work.
weights in the db just stay the same.
#9
I have the same problem with weights not getting saved with the latest checked-in version of this code. I also have the IE problem as well. Does anyone have this module working (as in dragging and dropping and saving) in both IE and FF?
#10
I'm testing this out a bit today. I'm using Firefox, and I found that if I go to the admin/settings/nodeorder page and turn on "Only show titles when ordering nodes" that drag-and-drop works fine. Could you please test that out on your site?
#11
I changed the setting and it still does not work in FF. But this is with one of the patches mentioned on another issue dealing with the title and quotes.
#12
I've just verified that what's in CVS works on Firefox. Please try to limit your test case down to something as small as possible if you can't get it to work for you. Try creating just two tiny pages and put them in the same term. Then see if you can order the pages. If you are using some other node type, you'll need to make sure that the contents that are displayed are showing clean HTML. If there are missing
</div>s in there, you'll run into problems.Once you verify that things are working on Firefox, please test it on IE and let us know what's happening.
Thanks,
Marc
#13
okay....using CVS version on a Drupal 4.7.6 install. I created a new vocabulary and added a couple of terms. I then created two new page nodes and assigned them to the first term in the category. When I tested on FF the drag and drop worked BUT it did not save the positions. When I tested on IE drag and drop did not work at all. (IE 7)
#14
Can I get into your site to help you debug this?
#15
Please upgrade to 6.x for the latest and greatest that builds upon core's drag and drop.