[D6] Filemaker

Quite a nice implementation. I'm currently working with a client with a large filemaker database and a possible need to connect this to a website. This seems a good potential way to go.

Very interesting just received an email. Will need to download this extension tomorrow. I will be creating a recruitment portal with over 100,000 client records planned start in 2-3 months time using a Filemaker database back end. This could be something I would love to try out. Was planning on Joomla development but see very little integration on that system. This could be just what I've been waiting for. Will check this out tomorrow.

@tedstein: please make sure that any external php files (e.g. primary API directory (FileMaker) and the gateway file) are placed inside the "/sites/all/libraries" folder, with instructions to create the libraries folder if it is not already there.

This have the added advantage of keeping those external files in the event that your users are using Drush to update your module, thus keeping your module in a working state. Drush deletes any module folder that it is updating, so you would save your users to reinstall the external php files after each updates.

This FileMaker module is the perfect candidate for a new project application on d.o. I plan to use it.

I will test and review this module later, if time permits.

As per my previous comment.

Installation instructions for the FileMaker API are confusing. These start with "libraries" and finish with "modules".

Create a directory in sites/all/libraries named filemakerapi.

Place the FileMaker API in the filemakerapi folder.


The files you added should look like this:

sites/all/libraries/filemakerapi/FileMaker/
sites/all/modules/filemakerapi/FileMaker.php

Once the FileMaker API is copied into the module directory structure (as shown above), enable the module.

I believe you meant to put everything in sites/all/libraries/filemakerapi/

Also, in the filemaker.info file, reference to the libraries module is wrong:

dependencies[] = libraries

Looks like you do not need to install the Libraries API module (http://drupal.org/project/libraries), which the dependencies[] = libraries would look for. I believe we do not need to install this module.

I have a test FileMaker Server installation that I will use to test out this module again once the instructions are fixed.

I now believe we need to install the Libraries modules. But I think the first part of the instructions should stille be rewritten.

I should be able to configure a first connection to FileMaker tomorrow and see how it goes.

I installed the FileMaker API inside the Libraries folder. But I still get an installation error.

FileMaker	FileMaker API was not found
The FileMaker API for PHP is required for this module. The API comes with your copy of FileMaker server and should be placed in sites/all/libraries.

I will wait for a new version to review this.

I was able to install this filemaker module and get the Filemaker library installed as per the instructions and get a green:

FileMaker FileMaker API is installed correctly message.

Not sure what the problem is with xmacinfo's install of the filemaker Library, but here is what I get with an ls -R from the libraries directory:

dru:/home/drupal6/trunk/drupal/sites/all/libraries$ ls -R filemakerapi/
filemakerapi/:
FileMaker/  FileMaker.php  FileMaker.zip

filemakerapi/FileMaker:
Command/     conf/   Error.php  Implementation/  PEAR.php    RelatedSet.php  Standalone Package Source.txt
Command.php  Error/  Field.php  Layout.php       Record.php  Result.php

filemakerapi/FileMaker/Command:
Add.php  CompoundFind.php  Delete.php  Duplicate.php  Edit.php  FindAll.php  FindAny.php  Find.php  FindRequest.php  PerformScript.php

filemakerapi/FileMaker/conf:
filemaker-api.php

filemakerapi/FileMaker/Error:
de.php  en.php  fr.php  it.php  jp.php  se.php  Validation.php

filemakerapi/FileMaker/Implementation:
Command/  CommandImpl.php  FieldImpl.php  FileMakerImpl.php  LayoutImpl.php  Parser/  RecordImpl.php  RelatedSetImpl.php  ResultImpl.php

filemakerapi/FileMaker/Implementation/Command:
AddImpl.php           DeleteImpl.php     EditImpl.php     FindAnyImpl.php  FindRequestImpl.php
CompoundFindImpl.php  DuplicateImpl.php  FindAllImpl.php  FindImpl.php     PerformScriptImpl.php

filemakerapi/FileMaker/Implementation/Parser:
FMPXMLLAYOUT.php  FMResultSet.php

hope this helps.

Looks like you corrected the README.txt file. As noted in #22, instructions were confusing. Thank you for that.

I will try testing the new version on github tomorrow with FileMaker Pro 11 Server.

That being said, I was trying out the file published in #20, not any version published on Github. So to remove any confusion, you may upload the latest version here in this issue.

As for #26, looks like @DarrellDuane can move this to RTBC. No need to delay RTBC for me if someone else have more success than me. We need this module on D.O.

:-)

Per #28 above!

@tedstein: I have the “FileMaker API is installed correctly” message.

Can I ask you a support question about proper FileMaker Pro Server Deployment? I'd like to know if I can deploy FMPro Server on a single machine or two to use the Drupal module and if FileMaker needs it's own web server in addition the the Drupal site.

Thanks for your hard work! I'm having some problems though...
I get the following:
[Mon Feb 21 05:32:09 2011] [error] [client xxx.xxx.xxx.xxx] PHP Fatal error: Cannot redeclare filemaker_connection_form() (previously declared in /Library/WebServer/Documents/modules/tedstein-filemaker-8824d82/filemaker.module:1152) in /Library/WebServer/Documents/modules/tedstein-filemaker-8824d82/filemaker.admin.inc on line 170, referer: http://xxx.xxx.xxx.xxx/admin

and the same error but with the filemaker_connection_submit function on line 200 happens as well when I comment out the whole filemaker_connection_form() function.

These come with a WSOD which appears when trying to use the admin page of the module (not the content create page though).

Trying to tinker around to get it to work, I simply commented out the offending function declarations in the filemaker.admin.inc file. This got me to the point where I could actually get to the admin page and even add a connection, but there are serious problems that came with such a crude approach and it doesn't seem like I'm on the right path; the content made while the functions were commented out behaves strangely. I do however get to see some layouts and records so the filemaker connection and API seem to be working. If there is any more info I can provide I'd really appreciate a hand with this.

@tedstein: Thanks for your support. You did answer my question.

Please read all the following and the links provided as this is very important information about your CVS Application.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:Migrating from CVS Applications to (Git) Full Project Applications.

• If your application has been "needs work" (or "postponed (maintainer needs more info)"), your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.
• if the status of this application is a different one, it will be changed to "postponed"; you will be able to reopen it by following the instructions in the above link.

It was a mistake from my side; I should have moved the issue to the other queue.

I have been using this module for a couple months now, entering work hours on a remote filemaker database for an employer. works like a charm, have had no bugs as of yet and i understand there are a couple new features in the works, including token and rules integration! please approve access to get this project out there for everyone to peruse and work on together!

Sorry, I have to set this back to needs work, there might be a security issue here, see below.

- return array('administer filemaker', 'create mode', 'browse and find mode', 'layout mode', 'FileMaker nodes');
Some of these permissions are quite hard to understand, you might want to try to change them into something that's more readable/understandable. D7 will allow to provide a translated title and description.

- $items['node/%/find'] = array(
Same for the other similar menu items. You can use 'node/%node/find' here and "'page arguments' => array(1). This will automatically call node_load() and pass a fully loaded node object to your callback. (You can do the same for your access callback). This will save the additional node_load() call in your page callback and also makes the arg(1)-stuff unecessary as using arg() is discouraged.

-

  $nid = arg(1);
  $tab = arg(2);
  $fmid = arg(3);
  $delete = arg(4);

And similar. This isn't necessary, drupal automatically passes additional arguments in the URL after your defined router menu item to your page callback. So you can simply use the following(together with the menu change from above)

function filemaker_browse_tab($node, $tab = NULL, $fmid = NULL, $delete = NULL)

-

    // Delete?
    if ($delete == 'delete') {

      filemaker_delete_record($node, $fmid);

      // Reload this tab with new found set.
      drupal_goto('node/' . $node->nid . '/' . 'browse');
    }

This is problematic. Someone could execute a so called CSRF attack by simply tricking you into opening that URL (in a hidden iframe for example) and it would delete that record automatically. You need to protect this. The easiest way is to integrate a confirmation form, because all forms in Drupal are automatically protected against something like this.

hook_menu:
'page callback' => 'drupal_get_form',
'page arguments' => array('filemaker_record_form', 1),

And then just:

function filemaker_record_form(&$form_state, $node, $tab = NULL, $fmid = NULL) {
  
}

No need for the helper function anymore. Note that in Drupal 7, you also need $form before $form_state, this has been added for consistency with the validate/submit functions.

Just pass the arguments as additional arguments to drupal_get_form(), like "drupal_get_form('filemaker_record_form', $node);". Obviously, you also need to update the function signature of whatever function this is called in.

#tedstein: You need to leave it at “needs review”, until Berdir or someone else marks this as “Reviewed and tested by the community”, also known as RTBC.

“Fixed” will be set only when you will be allowed to create releases for your project.

I had a short look over the commits, the changes look good to me. Not marking as RTBC since I've never actually used the module.

phrancescot in #43 already marked the module as RTBC and he is using it so I'd suggest that he tries the latest version and if that works ok, marks it again as RTBC :)

so long as the coding is all kosher (and from Berdir's comments it looks as though it's very solid) the interface is still bug-free from my standpoint and the delete form confirmation is definitely a good addition. i am able to easily and with no problems I can see:

• Create a record type in create mode.
• Find the record find mode.
• Delete the record.
• Use layout mode to add a field from those available within the FM layout.
• See that field in browse mode.
• Delete the field in layout mode (does not/should not affect FM layout/fields).

Looks ready to me. Let's get this out there for more community feedback and potential improvements!

This is a well needed application.
I have gotten requests from many people about having filemaker talk to drupal.
This is a great solution to that problem!
Keep up the good work, Ted, and much success in this project.

Jerry

Hi, I just tested the latest version of the module - downloaded from tedstein's sandbox - and everything seems to work great. I'm happy to do more testing if it helps get this module approved. What I did was similar to phrancescot, but I also tested adding and deleting FileMaker connections and portals, as well as value lists. Testing was no problem because I needed to do some web FileMaker work anyways.

Is there anything I can do to help speed up the approval process? Now that I have the module installed, I'm happy to do more testing.

FileMaker talking to Drupal will make my life so much easier.

Full disclosure, I know Ted personally, if it matters.

With Ted's help, I recently troubleshot a connection issue with the module (that turned out to be an issue with my FileMaker Server host), and took a tour of its functionality. From what I can see, this module works flawlessly and will be very useful for anyone wanting to interact with FileMaker databases using Drupal. I look forward to this module getting approval.

Kind regards,

Chris

@tedstein: Nice job at getting user feedback :)

This issue is RTBC so there isn't much to be done except someone who does have the necessary privileges needs to change your project to be public. It's taken a bit longer because most people with that permission are probably currently busy attending DrupalCon. AFAIK, there will be a project application review sprint tomorrow, so there is a good chance that it gets done by then!

This review was done, in part, at the DrupalCon Chicago Code Review.

You have been approved! Quite an application issue. Thank you for your patience and dedication on this process. We look forward to your continuing contributions to Drupal and its community. Please read the following pages (and subpages) about Git usage and Drupal best practices:

• Git handbook
• Drupal best practices

Thank you to the following people for helping with this review:

• @kiamlaluno
• @xmacinfo
• @DarrellDuane
• @dbos
• @phrancescot
• @Berdir
• @phrancescot
• @jerrysalem
• @jsalt
• @chrisostrom

--
Please be patient with the Full Project Application Review process as it is done by volunteers, we understand that this process is not the most efficient. The goal of the process is to ensure that contributions to the Drupal community remain valuable, and to help applicants build their skills as contributors.

@tedstein: Congratulations! Now, let’s rock all those FileMaker databases. :-)