Closed (fixed)
Project:
Brilliant Gallery
Version:
7.x-1.0
Component:
Miscellaneous
Priority:
Major
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Dec 2010 at 00:41 UTC
Updated:
1 Oct 2011 at 01:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
superflyman commentedComment #2
vacilando commentedYes, should be there in a few days. Based on 6.x-4.x-dev.
Comment #3
superflyman commentedAwesome, thanks for all of your efforts and for the quick response!
Comment #4
daviesap commentedThis is good news! I was worried too as I have a couple of sites using Brilliant Gallery. Had a look around for a similar module just in case, but couldn't find anything that worked as well as BG.
I can't ger random working on the current release though. Not sure why. Is this likely to work in the new version?
Thanks,
Andrew
Comment #5
JohnnyX commentedAny plans/ date for a stable/ working release today?
Comment #6
JohnnyX commentedAt the moment brilliant gallery doesn't work with Drupal 7.0...
Also latest dev found in all releases is broken, right?
Comment #7
geistteufel commentedCould you support colorbox? That's the only cute zooming tools like LightboxV2 that support perfectly Drupal 7. Could help.
Comment #8
anruethersubscribe
Comment #9
daviesap commentedI've redone my pages In D7 using one big static image which links to a Colourbox slideshow (previously, I had several thumbnails which linked to a slideshow using Brilliant Gallery)
My new method uses Drupal's built-in image processing (Which is fab!) and am very pleased with the result. http://www.flair.Ltd.uk/content/hsbc-presents-wimbledon-2010
Disadvantage is having to upload all the images one at a time which is a bit tedious. Initially this was a stop gap whilst waiting for BG to come out but think I'll keep it!!
Comment #10
W32 commenteddaviesap, can you describe your method more precisely... php example ? I am novice in drupal.
Comment #11
daviesap commentedHi
Note I am not using the Brilliant Gallery module anymore.
I used the Colorbox module to show a single large image. Clicking on that image then shows a Colorbox slideshow (just like lightbox in Brilliant Gallery)
PM me if you need more info as I am conscious that this is a Brilliant Gallery issue queue and so this is not relevant here.
Comment #12
tonycpsu commentedSubscribing.
Comment #13
SailingFortuitous commentedHello. Any update on the move to D7?
Comment #14
gilgabar commentedThe attached patch makes brilliant gallery functional in D7. It could still use a lot of work, but it satisfies my basic usage requirements for now. The patch does a lot of cleanup, renaming files to match standard conventions, removing debug code, removing unused code, improving documentation, etc. It's entirely possible things were moved or removed that should not have been, but that can be sorted out in the issue queue.
Off the top of my head, some further issues / changes that could be made:
- More documentation. I added comments to some functions, but there are several that still need to be documented.
- More code cleanup. Running it through Coder would probably reveal a lot.
- The image rendering/resizing functionality is very similar to imagecache/image style functionality that is part of D7. It may be possible to use that and reduce the amount of code that needs to be maintained here.
- I moved the views code around and updated the hook names, but I didn't touch the actual code, so whatever brilliant gallery does with views needs to be updated still.
- It looks like html lists have displaced tables as the preferred way to render galleries which is great, but the way that was implemented with inline styles just doesn't work. It makes it impossible to override those styles from your theme and that isn't acceptable. It was doing that so that it could dynamically size the container to constrain the width and thus the number of columns. Personally I don't think that is a worthwhile feature to maintain. With a table it is necessary to specify the number of columns. The real benefit of floated list elements is that they fill whatever space they are given without specifying columns. If someone needs more control than that then they can use CSS in their theme. So I would recommend eliminating the columns setting entirely.
- The cache directory that lives in the files directory needs to be created manually. It currently throws a bunch of unhelpful errors if it does not exist. So ideally that directory should be created if it does not exist and some more helpful errors should be displayed if it can't be created.
- The brilliant_gallery_image_arrays table is basically just a cache table, so it may make more sense to implement that using the drupal cache system.
- The admin management page should use the form api instead of the concatenated custom form it builds currently.
- The function render_brilliant_gallery() should be refactored to separate the presentation elements from the logic. Theme functions should handle the presentation. It may make sense to build a render array there. That may also help to reduce what appears to be code duplication on the admin management page.
- I added colorbox support. I haven't checked which other lightbox type modules are supported in D7, so any unsupported ones may need to be cleaned out.
Comment #15
Wooster commented@Gilgabar
I'm using a new installation of Brilliant Gallery, with your patch on the listed drupal 7 version, (as in, the module was installed patched).
I'd suggest, in model tab, when linking to the configuration for Brilliant Gallery, it links to /admin/config/media/brilliant_gallery as opposed to just admin/config/media . It doesn't make sense when there's only one admin tab for Brilliant Gallery
Second... I may be doing something wrong... but I can't seem to display any galleries. The admin panel identifies the folders, and sub folders, shows all the images listed in the folders... but on the main brilliant gallery page, I'm getting a big nothing.
Comment #16
gilgabar commentedThe issue with the configure path on the modules page is just due to a typo. The relevant line of the info file should read: configure = admin/config/media/brilliant_gallery/settings.
As I mentioned this patch is just good enough for my purposes. I don't use the all galleries page (example.com/brilliant_gallery), so I made no effort to get that to work. I would actually recommend getting rid of that page entirely, but also make sure that it is possible to display all galleries via the input filter if that functionality is desired. If someone does need that functionality it makes more sense to give them the flexibility to display it in whatever context they desire and at whatever path they desire rather than hard coding the page and path.
It looks like the way the code works now that page will display any loose images in your gallery folder, but not images within another folder in your gallery folder. Try to display a gallery via the input filter. That should work.
Comment #17
Wooster commented@Gilgabar
Alright, Thanks a ton. now I know what you meant. I was confused when you said the mod suited your purposes... and yet gave every indication of being a dud. When you mentioned the input filter I was a bit surprised. But now I've got it working... admittedly, not how I expected, but it works, and it works nice.
Thanks again!
Comment #18
gilgabar commentedI spent some time on this over the weekend and made some progress. Rather than post patches here every time I make some changes I've set up a sandbox http://drupal.org/sandbox/gilgabar/1244482. If anyone has the time and interest I would love to get some feedback on the direction I am going. It is essentially a complete rewrite at this point and I'm just scratching my own itch, so any criticisms or comments are welcome.
Some of the changes:
- image styles: I was able to replace a few hundred lines of code with a single function call. You can set default styles for thumbnail and full size images on the settings page and you can also override both in your bg tags if desired.
- lightbox hook: Adding support for new lightbox plugins is easy now with hook_brilliant_gallery_lightbox_info(). I've included support for Colorbox, Lightbox2, and Shadowbox. Using a hook means you can add support for anything else from your own custom module without hacking brilliant gallery.
- classes: An object oriented approach should allow for better organization and code reuse. Autoloading should also reduce memory usage when brilliant gallery isn't being used.
- tags: Using image styles made some of the tag parameters obsolete. It supports the old style tags with ordered parameters, as well as new style tags with named parameters. The location parameter supports a couple special types. A '*' tells it to display everything in the root directory. A '?' tells it to display a random gallery. A new parameter 'recursive' allows you to control whether it should look in subdirectories for additional images to display. So you could get a gallery of all the images in all your galleries using [bg|location=*|recursive=true]. I will try to update the readme in the sandbox with more detailed descriptions of parameter changes.
Not yet implemented:
- file import: Pluggable file importing would allow the use of something like Plupload to add new galleries and images via the admin management pages. It would also be able to replace the existing method of adding picasa galleries via a bg tag. Support for importing from Flickr, Facebook, or any other service could also work.
- admin: The admin pages display galleries and images in those galleries, but the hiding individual image functionality isn't implemented yet.
-caching: There isn't any caching implemented yet. Filter format results get cached anyway, so for typical usage it isn't an issue. The cleaned up API makes it easy to add a brilliant gallery in your theme without using a filter format though, so for those cases caching would be useful.
There are probably plenty of bugs, so if you are brave enough to look for them you can report them in the sandbox issue queue.
Comment #19
bart.janssen commentedOk installed perfect with the patch but I don 't see how to make a gallery now.
If I make a new page/node I don 't see some option to choose for gallery. is it still working with [bg|folder/some_picture] or does I have to do somthing more I really need a node based gallery for using with quicktabs.
kind regards
Comment #20
drpchris commentedsubscribe
Comment #21
gilgabar commentedI will try to throw together some documentation for this in the near future. It mostly works the same way. Any tags you used in a D6 version should still work. If you installed the patch and see your galleries/images showing up correctly on the admin page, the most likely issue is that you need to activate the input format. Go to admin/config/content/formats and click the configure link for the format you want to use with Brilliant Gallery. Make sure the "Brilliant Gallery Tag" filter is selected. You may also need to rearrange the filter processing order depending on which other filters you use on that format.
Comment #22
vacilando commentedFirst (hopefully!) stable D7 release is there! All comments, esp. bug reports and patches will be most welcome (please open a separate issues).