First off, I have read the other issues regarding the "Mark all topics read" link, particularly http://drupal.org/node/940244. I'm creating this as a new issue because I think these other issues have ignored a legitimate bug regarding the display of this link on forum container pages.

When a site is set up like this:

-Forum
-- Sub-forum

...I understand the explanation, in the aforementioned node, as to why clicking the "Mark all topics read" link on the page for Forum would not mark all topics within Sub-forum as read. However, when a site is set up like this:

-Container
--Sub-container
---Forum
----Sub-forum

...the links on the pages for Container and Sub-container that read "Mark all topics read" have no purpose, because topics cannot be posted directly into a container, meaning there will never be anything in a container to be marked as read. These links should be removed from container pages, because they have no function and serve only to confuse end users.

Also, if they were made functional (i.e., if they did mark all of the contained forums' topics as read), then the links on the container pages should read "Mark all forums read", like the link on the forum overview page reads, which works (i.e., clicking it marks all topics in all forums and sub-forums as read).

CommentFileSizeAuthor
#3 af-#992428.patch4.57 KBmichelle

Comments

michelle’s picture

Version: 6.x-1.1 » 6.x-2.x-dev

Committed to 1.x. This should be fixed in 2.x as well so moving version.

Michelle

michelle’s picture

Just an FYI in case someone else jumps in here... I've got this pretty much done on my dev site. Just need to fix a goof and test it. Too tired to finish tonight.

Michelle

michelle’s picture

Version: 6.x-2.x-dev » 7.x-2.x-dev
Status: Active » Patch (to be ported)
StatusFileSize
new4.57 KB

Ok, fixed this, though afterwards I realized that the entire forum tools jump down really doesn't make sense on containers. Will address that separately. Also fixed the fact that the jump menu wasn't checking if a person even had access to mark all read.

Patch attached with the changes to hopefully make it easier to get these in D7.

Michelle

troky’s picture

Status: Patch (to be ported) » Fixed

Ported. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.