Links passed to theme_links are not keyed resulting in invalid class names in the markup [#994006]

The problem is the way block_edit is calling theme_links. From the documentation: $links A keyed array of links to be themed. However in block_edit_preprocess_block() and block_edit_preprocess_node() a non keyed array is being passed to theme_links.

I've attached a patch that adds a generic incrementing class to each item in the link array that is passed to theme_links

Comment	File	Size	Author
	keyed_array_for_theme_links.patch	5.77 KB	pifantastic

Comments

Comment #1

joelstein commented 27 December 2011 at 20:36

Good idea, however, I think using keys relevant to the task contained in the link is more intuitive, and is easier to target if, say, you want to hide the "view" link.

Committed 6.x-1.x:
http://drupal.org/commitlog/commit/7690/ae726f9b17441d428a02f396eb34ecb1...

A new release will be available shortly.