Add a setting to disable releases for sandbox projects

Yup sounds great. I'm happy to see this split out from #986718: Add support for sandbox projects since that patch is already getting pretty big. ;)

Thanks,
-Derek

adding tag

#986718: Add support for sandbox projects landed. This can now happen.

Tagging for Git Sprint 7.

Tagging for Git Sprint 8

Mostly looks good. A few nits:

A) These functions need the word "alter" in their names:

+  if ($form_id == 'project_settings_form') {
+    return project_release_project_settings_form($form, $form_state);
+  }
+  if ($form_id == 'project_promote_project_form') {
+    return project_release_project_promote_form($form, $form_state);

B) Instead of duplicating this whole query, I'd rather just initialize a variable that holds the value for releases in a conditional and then have one query:

+  if (variable_get('project_release_sandbox_disable_releases', FALSE) && $node->project['sandbox']) {
+    db_query("INSERT INTO {project_release_projects} (nid, releases, version_format) VALUES (%d, %d, '%s')", $node->nid, 0, '');
+  }
+  else {
+    db_query("INSERT INTO {project_release_projects} (nid, releases, version_format) VALUES (%d, %d, '%s')", $node->nid, 1, '');
+  }

I generally find queries a bit hard to scan and see differences. I think it makes the code clearer if we just conditionally define $releases in the if and then have a single query with that as the argument.

C) I generally find variables that are named and behave in the negative a bit harder to grok in the code, since you often do double-negative logic with them. I think the code would probably be clearer if the variable was actually called something like project_release_sandbox_allow_releases and the UI was changed to reflect that.

Frankly all of these are just cosmetic optional fixes for code legibility. So, I almost hate to set this to 'needs work'. But, they should be very quick to fix (at least A and B). I leave C up to you, just wanted to raise it but I don't consider it a blocker for a commit.

Looks good. By my tastes, #11 is easier to read re: C. ;) Go figure... ;) Anyway, commit at will.