Check all cases of multilingual newsletters before relase.
Let's try to make the system reliable.

Comments

miro_dietiker’s picture

If sending a newsletter with translated nodes there are important conditions:
- Both newsletter nodes should share the same
-- newsletter term: Choosing different terms will lead to an error
-- publishing state: Any node with unpublished state will lead to ignore

Checking a setup with
- default language english
- first translation language german

Having a bunch of subscribers.
- users with none / default and alternative languge preference
- anon subscriber with none / default and alternative languge preference
(That's 6 cases!)

Test (single mail) sending cases:
- Newsletter source != default language
-- user with source language
-- user with translated language
-- anon subscriber with source language
-- anon subscriber with translated language
-- user without preference
-- anon subscriber without preference
- Newsletter source = default language
-- user with source language
-- user with translated language
-- anon subscriber with source language
-- anon subscriber with translated language
-- user without preference
-- anon subscriber without preference
All tests passed.

I wonder if there's a lovely simpletest integration to automate such tests...

miro_dietiker’s picture

Status: Active » Fixed

Spool deletion also tested, works cleanly.

Also real sending does the language switch.
But the reported send counts are wrong:
Translation source node reports ALL recipients while all translation nodes report ZERO sends - although the correct sending separation happened.
See separate issue for this:
#875672: Wrong "Sent" numbers on "Created issues" list

Since fixing the counter needs an API rewrite we'll release it with wrong counters by intention.

miro_dietiker’s picture

StatusFileSize
new5.64 KB

Note i've committed some improvements while testing, see attachment.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

miro_dietiker’s picture

Version: 6.x-2.x-dev » 7.x-1.x-dev
Assigned: Unassigned » berdir
Status: Closed (fixed) » Patch (to be ported)

Possibly this should be checked, if port is needed to D7.

miro_dietiker’s picture

berdir’s picture

Status: Patch (to be ported) » Needs review
StatusFileSize
new2.56 KB

Looks like the patch #3 fixes things which don't exist in 7.x-1.x. Ported what was applicable and added the simplenews_clear_spool_node() function and also added the corresponding parts in hook_node_delete().

berdir’s picture

Tagging

berdir’s picture

StatusFileSize
new6.95 KB

And now with tests. Which showed that the existing code resulted in a fatal error, so fixed that too.

berdir’s picture

Status: Needs review » Fixed

Commited.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

miro_dietiker’s picture

Issue tags: +test candidate

Oops, correct tagging.