Closed (fixed)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
12 Dec 2010 at 22:49 UTC
Updated:
26 Dec 2011 at 02:05 UTC
Jump to comment: Most recent file
Comments
Comment #1
miro_dietikerIf sending a newsletter with translated nodes there are important conditions:
- Both newsletter nodes should share the same
-- newsletter term: Choosing different terms will lead to an error
-- publishing state: Any node with unpublished state will lead to ignore
Checking a setup with
- default language english
- first translation language german
Having a bunch of subscribers.
- users with none / default and alternative languge preference
- anon subscriber with none / default and alternative languge preference
(That's 6 cases!)
Test (single mail) sending cases:
- Newsletter source != default language
-- user with source language
-- user with translated language
-- anon subscriber with source language
-- anon subscriber with translated language
-- user without preference
-- anon subscriber without preference
- Newsletter source = default language
-- user with source language
-- user with translated language
-- anon subscriber with source language
-- anon subscriber with translated language
-- user without preference
-- anon subscriber without preference
All tests passed.
I wonder if there's a lovely simpletest integration to automate such tests...
Comment #2
miro_dietikerSpool deletion also tested, works cleanly.
Also real sending does the language switch.
But the reported send counts are wrong:
Translation source node reports ALL recipients while all translation nodes report ZERO sends - although the correct sending separation happened.
See separate issue for this:
#875672: Wrong "Sent" numbers on "Created issues" list
Since fixing the counter needs an API rewrite we'll release it with wrong counters by intention.
Comment #3
miro_dietikerNote i've committed some improvements while testing, see attachment.
Comment #5
miro_dietikerPossibly this should be checked, if port is needed to D7.
Comment #6
miro_dietikerHere some additional references to multilingual issues
#1070730: Replace i18n_selection_mode with new concept
#1177640: Add own explicit base url to send reliably
#1305318: Translation of newsletter categories
Comment #7
berdirLooks like the patch #3 fixes things which don't exist in 7.x-1.x. Ported what was applicable and added the simplenews_clear_spool_node() function and also added the corresponding parts in hook_node_delete().
Comment #8
berdirTagging
Comment #9
berdirAnd now with tests. Which showed that the existing code resulted in a fatal error, so fixed that too.
Comment #10
berdirCommited.
Comment #12
miro_dietikerOops, correct tagging.