this was fixed in the dev version (see #948202: reversed aspect ratio is used) but not in the recommended release (as of the 12/2 release).

Comments

nils.destoop’s picture

nils.destoop commented

The patch in your link was removed: see #988498 for more details

zdean’s picture

zdean commented

So #988498: Aspect ratio is backwards for crop (patched) says that the patch was applied on Dec 9, but the latest release was updated on 12/2. Sorry if I'm missing something, but could you let me know what I'm overlooking? Thanks in advance for your help.

nils.destoop’s picture

nils.destoop commented

since #988498: Aspect ratio is backwards for crop (patched) the aspect ratio is calculated as: width / height.

in #948202: reversed aspect ratio is used the ratio was calculated as: height / width

Since version 1.6 from jquery ui, the correct calculation is width / height: http://bugs.jqueryui.com/ticket/3450

I think everyone uses 1.6 or higher, so widt / height should be the correct calculation

nils.destoop’s picture

nils.destoop commented

wrong comment

zdean’s picture

zdean commented

I'm using version 1.7.3 and the ratio is still coming out reversed...will try the dev instead.

zdean’s picture

zdean commented

here's a more detailed description of what's happening...

When I open the window to edit the crop on an image, the INITIAL crop region reflects the dimensions that I've set (with width/height being respected). If I move the crop area around, it works fine. However, if I try to adjust the size of the crop area, the aspect ratio reverses.

Morpheu5’s picture

Morpheu5 commented

+1 here.

I can only add I have upgraded to Drupal 6.20, and this module's version is 6.x-1.1.

FallinHigh’s picture

FallinHigh commented

same here!

nils.destoop’s picture

nils.destoop commented

The problem should be fixed. can you check?

echoz’s picture

echoz commented

As of the Dec 24th dev version, all of the ratio bugs are fixed in my testing. Thanks for your prompt and great work on this!

zdean’s picture

zdean commented

I don't see an update to the 1.1. Was this update applied to the dev?

nils.destoop’s picture

nils.destoop commented

this is idd applied to dev

zdean’s picture

zdean commented

I have other issues with dev not working right...will this be applied to 1.1?

nils.destoop’s picture

nils.destoop commented

What are the other issues?

zdean’s picture

zdean commented

I'll create a separate ticket for the dev...but that shouldn't really matter to this ticket. This issue was opened for the aspect ratio problem in the Recommended Release of Dec. 2, not the dev release that @echoz commented about.

So, back to my question in #13, will this be applied to the Recommended release or is the Dev what everyone should be using?

nils.destoop’s picture

nils.destoop commented

It won't be applied to the latest release, because you can't commit anymore to released versions.
I'll release a new version after looking to #591026: Crop preview box not updating on drag when one dimension equals original image

nils.destoop’s picture

nils.destoop commented
Status: Active » Fixed
udane’s picture

udane commented

I have the same problem. What version do I have to use? Thanks

nils.destoop’s picture

nils.destoop commented

at the moment dev. But i will release a new version this week.

nils.destoop’s picture

nils.destoop commented
Status: Fixed » Closed (fixed)