Indenting used for e.g. $form['settings']['uselist'] = array(...); is not how it's done in core. *A lot* of spaces...

Comments

anarcat’s picture

anarcat commented
Title: Code style: indenting arrays » Make decisions coder-clean

We should make decisions coder-clean.

anders.fajerson’s picture

anders.fajerson commented

Almost exactly 2 years later. Cool. A lot of work has gone into the Advanced Poll module since this. You might want to borrowing code from there or consider merging the projects (although I'm aware of the history). Also nice to see a Drupal 6 port on the way.

anarcat’s picture

anarcat commented

So I have opened (yet another) issue about "Advpoll vs Decisions" that you may want to comment upon. I'd really like to hear your honest opinion on this.

In the meantime, i think that with the D6 rewrite, it may be difficult to merge whitespace changes back into Decisions, especially since those changes were often mixed up with real changes in the code.

anarcat’s picture

anarcat commented
Status: Active » Fixed

I've committed a code cleanup that mostly shuts up coder, apart from one function on which it panics on indentation.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.