media form elements don't respect '#required' property

This seems like a no-brainer. I don't have time to test right now, but my understanding was that the required property would "just work" and doesn't need to be additionally specified. Is this not the case? If I look in system.module, I don't see it specified in most element_info arrays.

I'm a bit foggy on this area of the code...

@bec: As always, you rock :)

Committed.

The default 'fid' of a media input is '0', that is, zero as a string. This is causing the check in media_element_validate to never catch an empty submission on a required field.

Additionally, $element['#title'] appears to be empty regardless of whether the form element has a label set or not, so I've modified the error thrown when a required field isn't found to use: $form_state['field'][$field_name][$lang]['instance']['label']

Patch attached.

#7 works for me

Though #7 needs to be re-rolled against the correct directory.

This patch won't work for a form element with the type set to 'media'.

  $form['fid'] = array(
    '#type' => 'media',
    '#title' => t('Image'),
    '#default_value' => array('fid' => '')),
    '#required' => TRUE,
  );

daffie: The media field has been deprecated.

@azinck: Thank you for the info. I have switched back to 7.x-1.x. I am following Media gallery to see how they will solve this problem.

per #7 and please patch against latest dev.

I fixed the label part.
Previous commit for another issue accidentally fixed the other part.
marking as fixed.

Not fixed for me. In a multi-value form one of the values that comes through is the text of the "add another" button which is a string, not an array. The existing method of checking for empty fails when it hits this string.

can you please incorporate your patch in the issue here #1558830: media_element_validate() has hardcoded $form_state values reference and does not work with unlimited

Done.

awesome, thanks:)