Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I opened this feature request and you added it crazy fast (THANKS). The feature looks like it returns a simple list of data, which is very useful.
I think it would be useful if this action returned the submission in the form of the webform_data data type. That way they have access to tokens as well.
Comment | File | Size | Author |
---|---|---|---|
#8 | webform_rules-fetch_webform_data-1953382-8.patch | 442 bytes | thomas.fleming |
Comments
Comment #1
stBorchertI've changed the return type to
list<webform_data>
but that didn't change anything (at least I didn't get any tokens for the loaded submissions).The data returned is created by
webform_get_submissions()
so its basically the same structure as available after submitting a webform.Comment #2
that0n3guy CreditAttribution: that0n3guy commentedLooking at webform_rules_rules_invoke_event(), it looks like the structure your sending to rules is way different than what
webform_get_submissions()
returns. I would guess thats why there is no token support. The data structure isn't the same.Comment #3
that0n3guy CreditAttribution: that0n3guy commentedAlso, return type of
list<webform_data>
is still a type of "list" isn't it? We want to returnwebform_data
. Right? (I've not spent much time coding for rules...)Comment #4
stBorchertNo, the action needs to return a list because you may want to get multiple submissions.
Comment #5
thomas.fleming CreditAttribution: thomas.fleming at inRESONANCE commentedLike stBorchert said, the action needs to return a list because you may want to get multiple submissions. However, the return type needs to be
list<webform>
since the data type defined inwebform_rules_rules_data_info()
iswebform
. Attached is a patch to fix this issue.Comment #6
thomas.fleming CreditAttribution: thomas.fleming at inRESONANCE commentedLike stBorchert said, the action needs to return a list because you may want to get multiple submissions. However, the return type needs to be
list<webform>
since the data type defined inwebform_rules_rules_data_info()
iswebform
. Attached is a patch to fix this issue.Comment #7
thomas.fleming CreditAttribution: thomas.fleming at inRESONANCE commentedComment #8
thomas.fleming CreditAttribution: thomas.fleming at inRESONANCE commentedOK, let's try adding that patch one more time :)