There are a few missing icons with some core and contrib modules. Can we add icons for the following:

  • Shortcuts (When drupal core shortcut module is activated) This could be a star icon.
  • Manage Display (when Display Suite is used)
  • New Draft (when using moderation (this could be the same as Edit)

Also, I wonder if we could have a generic icon so that there is something available for custom links added into the local tasks?

CommentFileSizeAuthor
#11 2920308-11.patch4.8 KBNeslee Canil Pinto
#10 2920308-10.patch4.46 KBSuresh Prabhu Parkala
#7 additional-icons-2920308-6.patch4.63 KBmcvjoyner
#4 additional-icons-2920308-4.patch1.57 KBfourg6x
#3 additional-icons-2920308-3.patch4.57 KBmcvjoyner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

javdich created an issue. See original summary.

mcvjoyner’s picture

mcvjoyner CreditAttribution: mcvjoyner as a volunteer and at Cheeky Monkey Media commented

Sounds good, I'll look into these.

mcvjoyner’s picture

mcvjoyner CreditAttribution: mcvjoyner as a volunteer and at Cheeky Monkey Media commented
FileSize
additional-icons-2920308-3.patch4.57 KB

I've added support for those elements, in the new patch. Please review.

fourg6x’s picture

fourg6x CreditAttribution: fourg6x at Cheeky Monkey Media commented
FileSize
additional-icons-2920308-4.patch1.57 KB

I've tested this and it's working but the was a minor typo for the "New Draft" icon, corrected on line 76 of the .css file.

I've added a minor adjustment as well to make the clickable area on rollover the full width of the region, not just overtop the icon (it makes interacting with the button a bit difficult as it slides out).

CloudSociety’s picture

CloudSociety CreditAttribution: CloudSociety at Cheeky Monkey Media commented

Tested. Patch #3 applied without issue, but patch #4 failed. 

Checking patch css/local_tasks.css...
error: while searching for:
  left: 0;
  transform: translateY(-50%);
  z-index: 9999;
  width: 150px;
  left: -110px;
  transition: all 0.25s ease;
  }


error: patch failed: css/local_tasks.css:12
error: css/local_tasks.css: patch does not apply
CloudSociety’s picture

CloudSociety CreditAttribution: CloudSociety at Cheeky Monkey Media commented
Status: Active » Reviewed & tested by the community
mcvjoyner’s picture

mcvjoyner CreditAttribution: mcvjoyner as a volunteer and at Cheeky Monkey Media commented
FileSize
additional-icons-2920308-6.patch4.63 KB

New patch created, includes fixes from #3 and #4. Please test.

mcvjoyner’s picture

mcvjoyner CreditAttribution: mcvjoyner as a volunteer and at Cheeky Monkey Media commented
Status: Reviewed & tested by the community » Needs review
Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Patch needs reroll

Suresh Prabhu Parkala’s picture

Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commented
Status: Needs work » Needs review
FileSize
2920308-10.patch4.46 KB

Please review the re-rolled patch.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab commented
FileSize
2920308-11.patch4.8 KB

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.