Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The configuration path used by the modules overview page is not correct. Currently it links to "admin/user/captcha/riddler" but it should point to "admin/config/people/captcha/riddler".
I added a patch to fix the configuration link.
Comment | File | Size | Author |
---|---|---|---|
#7 | configuration_path_info_file-2971545-7.patch | 385 bytes | alex_optim |
#5 | 0001-Changed-configuration-path-in-info-file.patch | 388 bytes | sgoelz |
0001-riddler-Changed-configuration-path.patch | 472 bytes | sgoelz | |
Comments
Comment #2
msankhala CreditAttribution: msankhala as a volunteer and at Material commented@sgoelz This patch does not apply well on 7.x-1.x branch of this module.
Looks like you have a manually downloaded version of this module, not the git clone of this version from https://www.drupal.org/node/142475/git-instructions/7.x-1.x/nonmaintainer
Comment #3
sgoelz CreditAttribution: sgoelz at Zebralog commented@msankhala Thanks for the information. I cloned the repository and created a new patch.
Comment #4
msankhala CreditAttribution: msankhala as a volunteer and at Material commented@sgoelz new patch looks good and applies cleanly. Only one small chance. According to the Drupal coding standard, each file should has single newline at the end of the file.
See https://www.drupal.org/docs/develop/standards/coding-standards#indenting
Missing single newline at end of the file.
Comment #5
sgoelz CreditAttribution: sgoelz at Zebralog commentedThanks for your patience and the information @msankhala
I modified the patch and added a new line at the end of the file.
Comment #6
msankhala CreditAttribution: msankhala as a volunteer and at Material commentedHi @sgoelz Thanks for the updated patch and having patience with all my input.
Looks like you added two newlines at the end of file. It should be exactly one newline otherwise git shows warning when applying the patch. See below
On another note the patch file name should follow this convention
[project_name]-[short-description]-[issue-number]-[comment-number].patch
Sometime people skips the[project_name]
or[short-description]
or both. So for your next patch the patch name should be something likeconfiguration-path-info-file-2971545-7.patch
If the file has a single newline at the end of file git diff will not show that line. If it has two newlines it will show that.
Comment #7
alex_optimSgoelz, Msankhala, Thanks for our work.
I updated patch. Please check.
Comment #8
msankhala CreditAttribution: msankhala as a volunteer and at Material commentedThe patch #7 applies cleanly. Thanks @alex_optim for the fix.
Comment #9
pifagor+1
Comment #10
pifagorComment #11
alex_optimComment #13
alex_optim