The configuration path used by the modules overview page is not correct. Currently it links to "admin/user/captcha/riddler" but it should point to "admin/config/people/captcha/riddler".

I added a patch to fix the configuration link.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sgoelz created an issue. See original summary.

msankhala’s picture

Status: Needs review » Needs work

@sgoelz This patch does not apply well on 7.x-1.x branch of this module.

modules/contrib/riddler ❯ git apply -v 0001-riddler-Changed-configuration-path.patch                                                 7.x-1.x
Checking patch riddler.info...
error: while searching for:
core = 7.x
package = Spam control
dependencies[] = captcha
configure = admin/user/captcha/riddler
; Information added by Drupal.org packaging script on 2018-03-17
version = "7.x-1.2+1-dev"
core = "7.x"

error: patch failed: riddler.info:3
error: riddler.info: patch does not apply

Looks like you have a manually downloaded version of this module, not the git clone of this version from https://www.drupal.org/node/142475/git-instructions/7.x-1.x/nonmaintainer

sgoelz’s picture

Status: Needs work » Needs review
FileSize
415 bytes

@msankhala Thanks for the information. I cloned the repository and created a new patch.

msankhala’s picture

Status: Needs review » Needs work

@sgoelz new patch looks good and applies cleanly. Only one small chance. According to the Drupal coding standard, each file should has single newline at the end of the file.
See https://www.drupal.org/docs/develop/standards/coding-standards#indenting

+++ b/riddler.info
@@ -3,4 +3,4 @@ description = Allows site administrators to add a simple question to form valid
\ No newline at end of file

Missing single newline at end of the file.

sgoelz’s picture

Status: Needs work » Needs review
FileSize
388 bytes

Thanks for your patience and the information @msankhala

I modified the patch and added a new line at the end of the file.

msankhala’s picture

Status: Needs review » Needs work

Hi @sgoelz Thanks for the updated patch and having patience with all my input.
Looks like you added two newlines at the end of file. It should be exactly one newline otherwise git shows warning when applying the patch. See below

modules/contrib/riddler ∙ git apply -v 0001-Changed-configuration-path-in-info-file.patch
Checking patch riddler.info...
0001-Changed-configuration-path-in-info-file.patch:12: new blank line at EOF.
+
Applied patch riddler.info cleanly.
warning: 1 line adds whitespace errors.

On another note the patch file name should follow this convention [project_name]-[short-description]-[issue-number]-[comment-number].patch Sometime people skips the [project_name] or [short-description] or both. So for your next patch the patch name should be something like configuration-path-info-file-2971545-7.patch

If the file has a single newline at the end of file git diff will not show that line. If it has two newlines it will show that.

alex_optim’s picture

Status: Needs work » Needs review
FileSize
385 bytes

Sgoelz, Msankhala, Thanks for our work.
I updated patch. Please check.

msankhala’s picture

Status: Needs review » Reviewed & tested by the community

The patch #7 applies cleanly. Thanks @alex_optim for the fix.

pifagor’s picture

+1

pifagor’s picture

alex_optim’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

  • alex_optim committed 67da1a4 on 7.x-1.x
    Issue #2971545 by alex_optim, pifagor: Change configuration path in info...
alex_optim’s picture

Status: Patch (to be ported) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.