Hi,

Thanks for the module! I have a feature request...

The Menu Item Extras module allows you to use the field UI to attach fields to menu_link_content entities with the bundle being set by the menu. At the moment it looks like multiversion won't work with it because it overrides the entity class (as does menu_item_extras).

I was wondering if you would consider offering support for it? Thanks in advance for your thoughts and time!

CommentFileSizeAuthor
#8 multiversion-menu_item_extras-3026961-8.patch7.61 KBsuzymasri
#5 multiversion-menu_item_extras-3026961-5-D8-AGAINST-RELEASE-do-not-test.patch9.21 KBAndyF
#4 multiversion-menu_item_extras-3026961-3-D8.patch9.12 KBAndyF
#2 multiversion-menu_item_extras-3026961-2-D8.patch11.54 KBAndyF
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AndyF created an issue. See original summary.

AndyF’s picture

AndyF CreditAttribution: AndyF at Fabb for Unipro Ltd commented
Assigned: AndyF » Unassigned
Status: Active » Needs review
FileSize
multiversion-menu_item_extras-3026961-2-D8.patch11.54 KB

Here's an initial patch, feedback most welcome - and I appreciate you might prefer to keep support outside of the (main) module. I've ported MenuLinkTest from simpletest to PhpUnit (well I say ported, it just worked!) but have left the old one in just so we can check everything runs green before perhaps removing it. (I ported it in order to extend it for a new basically identical test that runs with the menu item extras module enabled - I thought that made more sense than making a new simple test?)

Thanks again!

Status: Needs review » Needs work

The last submitted patch, 2: multiversion-menu_item_extras-3026961-2-D8.patch, failed testing. View results

AndyF’s picture

AndyF CreditAttribution: AndyF at Fabb for Unipro Ltd commented
Status: Needs work » Needs review
FileSize
multiversion-menu_item_extras-3026961-3-D8.patch9.12 KB

Sorry, my bad, git snafu, fingers crossed for the second go (:

(no interdiff please ignore first patch)

AndyF’s picture

AndyF CreditAttribution: AndyF at Fabb for Unipro Ltd commented
FileSize
multiversion-menu_item_extras-3026961-5-D8-AGAINST-RELEASE-do-not-test.patch9.21 KB

I've attached the exact same patch made against the beta28 release (ie with packaged info file) for CI.

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented
Status: Needs review » Needs work

I tested the patch but it didn't seem to work for me. The fields added from the menu_items_extra module are not being shown on the menu item edit page. +1 for this request though.

BramDriesen’s picture

BramDriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
CreditAttribution: BramDriesen as a volunteer and at Capgemini commented

This also needs a re-roll I think based on the core changes to the menu item storage (8.7.x) and this issue #3053970: Regression Drupal 8.7.x menu_ui broken with Multiverson not working with the core changes.

suzymasri’s picture

suzymasri
Location Greece
CreditAttribution: suzymasri at Pfizer, Inc. commented
Status: Needs work » Needs review
FileSize
multiversion-menu_item_extras-3026961-8.patch7.61 KB

Patch #4 re-rolled against beta33 release.