Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Recent commits have broken javascript coding standards.
yarn run v1.19.1
$ node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json .
/Users/alex/dev/sites/drupal8alt.dev/core/misc/dropbutton/dropbutton.es6.js
234:132 error Replace `⏎··········options.title⏎········` with `options.title` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/filter/filter.admin.es6.js
59:56 error Delete `⏎··············` prettier/prettier
61:1 error Delete `··` prettier/prettier
62:17 error Delete `··` prettier/prettier
63:1 error Delete `··` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/quickedit/js/theme.es6.js
37:25 error Replace `⏎······settings.id⏎····` with `settings.id` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/system/js/system.date.es6.js
41:46 error Replace `⏎··········/\\?(.?)/gi,⏎··········(key,·value)·=>·(dateFormats[key]·?·dateFormats[key]·:·value)` with `/\\?(.?)/gi,·(key,·value)·=>⏎··········dateFormats[key]·?·dateFormats[key]·:·value` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/toolbar/js/toolbar.menu.es6.js
200:69 error Replace `⏎······options.action⏎····` with `options.action` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/user/user.es6.js
50:267 error Replace `⏎············translate.strengthTitle⏎··········` with `translate.strengthTitle` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/modules/user/user.theme.es6.js
14:112 error Replace `⏎······translate.confirmTitle⏎····` with `translate.confirmTitle` prettier/prettier
/Users/alex/dev/sites/drupal8alt.dev/core/themes/stable/js/user.theme.es6.js
14:124 error Replace `⏎······translate.confirmTitle⏎····` with `translate.confirmTitle` prettier/prettier
✖ 11 problems (11 errors, 0 warnings)
11 errors, 0 warnings potentially fixable with the `--fix` option.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Proposed resolution
Fix them by running yarn run lint:core-js-passing --fix
Remaining tasks
User interface changes
None
API changes
None
Data model changes
None
Release notes snippet
None
Comment | File | Size | Author |
---|---|---|---|
#2 | 3091672-2.patch | 6.06 KB | alexpott |
Comments
Comment #2
alexpottComment #3
lauriiiLooks good! Thank you! 🙏
Comment #5
larowlanCommitted 0a69c9c and pushed to 9.0.x. Thanks!
c/p to 8.9.x
Comment #7
alexpottAs these errors are on 8.8.x too I cherry-picked it back to that branch.
Comment #9
larowlan