php drupal-check.phar modules/contrib/textfield_counter/
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/TextFieldCounterWidgetTrait.php (in context of class Drupal\textfield_counter\Plugin\Field\FieldWidget\StringTextareaWithCounterWidget)  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  344    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                         
  347    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                         
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/TextFieldCounterWidgetTrait.php (in context of class Drupal\textfield_counter\Plugin\Field\FieldWidget\StringTextfieldWithCounterWidget)  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  344    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                          
  347    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                          
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/TextFieldCounterWidgetTrait.php (in context of class Drupal\textfield_counter\Plugin\Field\FieldWidget\TextareaWithCounterWidget)  
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  344    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                   
  347    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                   
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/TextFieldCounterWidgetTrait.php (in context of class Drupal\textfield_counter\Plugin\Field\FieldWidget\TextareaWithSummaryAndCounterWidget)  
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  344    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                             
  347    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                             
 ------ -------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   src/Plugin/Field/FieldWidget/TextFieldCounterWidgetTrait.php (in context of class Drupal\textfield_counter\Plugin\Field\FieldWidget\TextfieldWithCounterWidget)  
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  344    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                    
  347    Call to deprecated method strlen() of class Drupal\Component\Utility\Unicode.                                                                                    
 ------ ----------------------------------------------------------------------------------------------------------------------------------------------------------------- 

                                                                                                                        
 [ERROR] Found 10 errors
CommentFileSizeAuthor
#8 textfield_counter-deprecated-3091693-8.patch946 bytes3li
#2 deprecated-3091693-2.patch1.17 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sergiu Stici created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
deprecated-3091693-2.patch1.17 KB

Here's the patch, please review.

bblake’s picture

bblake CreditAttribution: bblake at Phase2 commented
Status: Needs review » Reviewed & tested by the community

Verified it removes the deprecations and functionality looks good too.

jkswoods’s picture

jkswoods CreditAttribution: jkswoods at interactive investor commented

Looks good! I think it'd be great to get this committed with #3123816: Compatibility with Drupal 9

jastraat’s picture

jastraat CreditAttribution: jastraat at Technivant commented

Any chance this will be committed in the near future?

elgandoz’s picture

elgandoz CreditAttribution: elgandoz as a volunteer commented
Priority: Normal » Major

Yes, this patch made this module compatible with D9 long before it got released, now for me it's holding off the upgrade for few projects. Please @Jaypan merge this and #3123816.

chegor’s picture

chegor CreditAttribution: chegor as a volunteer commented

Can we go with this?

3li’s picture

3li
he/him
Primary language English
Location U.K. 🇬🇧
CreditAttribution: 3li as a volunteer commented
FileSize
textfield_counter-deprecated-3091693-8.patch946 bytes

Re-rolled on 8.x-1.11, #2 would not apply.

  • Eli.Stone authored 7bd580a on 8.x-1.x 
    Issue #3091693 by Sergiu Stici, Eli.Stone: Deprecated Code Report
Jaypan’s picture

Jaypan CreditAttribution: Jaypan commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks guys.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.