Job items are not set to active if the job has been rejected previously

+++ b/src/Tests/TMGMTUiTest.php
@@ -578,6 +577,69 @@ class TMGMTUiTest extends EntityTestBase {
+    // Check that job is in rejected and job item is in active state.
+    $job1 = \Drupal::entityTypeManager()->getStorage('tmgmt_job')->loadUnchanged($job1->id());
+    $this->assertTrue($job1->isRejected());
+    $item1 = \Drupal::entityTypeManager()->getStorage('tmgmt_job_item')->loadUnchanged($item1->id());
+    $this->assertTrue($item1->isActive());

That's not the idea. reject should not set it to active. only active should.

You need to resubmit the same job in the test.

First try with reject, that will change the status to rejected. check that status is reject and inactive. Then submit the same job again, this time with submit. Then check that job and item is active.

It would be a lot faster if we could do this through the API, for example in TmgmtCrudTest. set $job->translator and $job->settings['action'] (I think), then requestTranslation().

Be careful with unrelated fixes. You risk that your patch conflicts with others that might be changing those lines as well for another reason. Only fix coding standards and documentation in lines that you touch anyway.

Test looks good now. Was confused why you added the use, the problem was actually something else, the namespace was wrong. Fixed and committed:

diff --git a/tests/src/Kernel/CrudTest.php b/tests/src/Kernel/CrudTest.php
index 8903a28..a7fb80e 100644
--- a/tests/src/Kernel/CrudTest.php
+++ b/tests/src/Kernel/CrudTest.php
@@ -4,9 +4,8 @@
  * Contains \Drupal\tmgmt\tests\Kernel\CrudTest.
  */
 
-namespace Drupal\tmgmt\tests\Kernel;
+namespace Drupal\Tests\tmgmt\Kernel;
 
-use Drupal\Tests\tmgmt\Kernel\TMGMTKernelTestBase;
 use Drupal\tmgmt\ContinuousTranslatorInterface;
 use Drupal\tmgmt\Entity\Job;
 use Drupal\tmgmt\Entity\JobItem;