Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
Currently password_policy.info depend on ctools:ctools (>=8.x-3.1)
, which generate error message when running drush -y cr
if ctools-8.x-3.x-dev is installed.
This patch simply remove the enforced version checking.
Issue fork password_policy-3266516
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
hswong3i CreditAttribution: hswong3i at PantaRei Design Limited (Hong Kong) commentedComment #4
stijnhau CreditAttribution: stijnhau commentedThis shouldn't be merged.
If the versions needs to be above 3.1 we need to enforce this.
Also for your usecase you can use the composer require as syntax to tell composer a version number for branches.
Comment #5
2dareis2do CreditAttribution: 2dareis2do commentedFrom what I can tell specifying >=8.x-3.1 seems to conflict with paragraphs module when installing dev dependencies which I guess comes before password_policy in terms of lexicographical order. So we have"require-dev": {
...
"drupal/ctools": "3.x-dev",
pathauto specifies like so
"drupal/ctools": "*"
and of course password_policy 3.1
"drupal/ctools": "^3.1"
Looking forward to seeing ctools removed before upgrading.
Please ignore my previous. What ever issue I was having seems to have gone away. Also after reading up on versioning/aliases I don't think 3.x-dev should really conflict with "^3.1".
Comment #6
2dareis2do CreditAttribution: 2dareis2do commentedComment #7
chr.fritschCTools v4 was released and should be allowed as well
Comment #8
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedChaos Tool Suite (ctools) 8.x-3.8 was released on 1 Jul 2022 by japerry
https://www.drupal.org/project/ctools/releases/8.x-3.8
Chaos Tool Suite (ctools) 4.0.0 stable too was released on 1 Jul 2022 by japerry
https://www.drupal.org/project/ctools/releases/4.0.0
Thank you, Jakob for your time and for maintaining the excellent ctools module
Proposed resolution
Change
drupal/ctools
to~3.0 || ~4.0
in thecomposer.json
fileComment #9
2dareis2do CreditAttribution: 2dareis2do commentedMaybe should do like pathauto: e.g
"drupal/ctools": "*"
Comment #10
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedHappy with
"drupal/ctools": "*"
too :)Comment #11
the_g_bomb CreditAttribution: the_g_bomb at Cyber-Duck commentedPerhaps this issue can be closed in favour of the removal of ctools entirely in:
https://www.drupal.org/project/password_policy/issues/2877040
Comment #12
paulocsHey team! Thanks a lot, but can we focus our effort on #2877040: Remove dependency on CTools
Comment #13
Rajab Natshah CreditAttribution: Rajab Natshah at Vardot for Vardot commentedNoted;
Thanks, Paulo for direction :)
Comment #14
paulocsAs #2877040: Remove dependency on CTools was fixed, I'm closing this one... Thanks!
Comment #15
paulocs