Problem/Motivation

Currently password_policy.info depend on ctools:ctools (>=8.x-3.1), which generate error message when running drush -y cr if ctools-8.x-3.x-dev is installed.

This patch simply remove the enforced version checking.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hswong3i created an issue. See original summary.

hswong3i’s picture

stijnhau’s picture

This shouldn't be merged.
If the versions needs to be above 3.1 we need to enforce this.
Also for your usecase you can use the composer require as syntax to tell composer a version number for branches.

2dareis2do’s picture

From what I can tell specifying >=8.x-3.1 seems to conflict with paragraphs module when installing dev dependencies which I guess comes before password_policy in terms of lexicographical order. So we have

"require-dev": {
...
"drupal/ctools": "3.x-dev",

pathauto specifies like so

"drupal/ctools": "*"

and of course password_policy 3.1

"drupal/ctools": "^3.1"

Looking forward to seeing ctools removed before upgrading.

Please ignore my previous. What ever issue I was having seems to have gone away. Also after reading up on versioning/aliases I don't think 3.x-dev should really conflict with "^3.1".

2dareis2do’s picture

Version: 8.x-3.x-dev » 8.x-3.1
chr.fritsch’s picture

Status: Needs review » Needs work

CTools v4 was released and should be allowed as well

Rajab Natshah’s picture

Chaos Tool Suite (ctools) 8.x-3.8 was released on 1 Jul 2022 by japerry
https://www.drupal.org/project/ctools/releases/8.x-3.8

Note, this is the last feature release for ctools in the 3.x branch. All new features should be tested against 4.x. The 3.x branch is now in only critical bug and security mode.


Chaos Tool Suite (ctools) 4.0.0 stable too was released on 1 Jul 2022 by japerry
https://www.drupal.org/project/ctools/releases/4.0.0

Note, some ctools dependent modules may need to be updated to work with 4.x, which will require sites to remain on 8.x-3.8 until those modules are updated to support Drupal 10 and ctools 4.


Thank you, Jakob for your time and for maintaining the excellent ctools module

Proposed resolution

Change drupal/ctools to ~3.0 || ~4.0 in the composer.json file

2dareis2do’s picture

Maybe should do like pathauto: e.g

"drupal/ctools": "*"

Rajab Natshah’s picture

Happy with "drupal/ctools": "*" too :)

the_g_bomb’s picture

Perhaps this issue can be closed in favour of the removal of ctools entirely in:
https://www.drupal.org/project/password_policy/issues/2877040

paulocs’s picture

Hey team! Thanks a lot, but can we focus our effort on #2877040: Remove dependency on CTools

Rajab Natshah’s picture

Noted;
Thanks, Paulo for direction :)

paulocs’s picture

Status: Needs work » Fixed

As #2877040: Remove dependency on CTools was fixed, I'm closing this one... Thanks!

paulocs’s picture

Status: Fixed » Closed (fixed)