Assorted todo lists carried over from #3216978: [meta] Priorities for 2021-12-01 release of Drupal 7

PHP 8.1 compatibility fixes are top priority for the next release.

These are not necessarily in priority order.

For consideration

Issues which have had recent activity, and are RTBC.

Simple Fixes:

Important Fixes:

PostgreSQL performance improvements (backports from D8):

Unsorted Fixes:

CommentFileSizeAuthor
#16 3259739-16_noop.patch285 bytesmcdruid

Comments

mcdruid created an issue. See original summary.

mcdruid’s picture

mcdruid commented
Issue summary: View changes
mcdruid’s picture

mcdruid commented

Just added #3260196: [meta] Priorities for 2022-03-02 release of Drupal 7 to the release schedule, having discussed this with @Fabianx today.

We'll keep this issue for the June release, as the one in March will focus almost entirely on PHP 8.1 compatibility.

poker10’s picture

poker10 commented
Issue summary: View changes

I have summarized some backport patches which should (according to info from D8) greatly improve D7 PostgreSQL performance. I have added links to these issues to the issue summary to a separate category. All issues have patches ready and are passing all tests.

It will be great if someone can review them so they will be able to get into this June release.

Just for info how important this could be:

izmeez’s picture

izmeez commented
Issue summary: View changes

Added issue: #1374090: Editing a comment still changes creation date Patch in comment #100 is 6 years old and appears to solve the problem. Comment #112 confirms patch looks good and to be deployed on drupal.org website. A related issue #2288865: Same comment creation & changed date may no longer be relevant as noted in the interdiff of the patch in comment #100.

izmeez’s picture

izmeez commented
Issue summary: View changes

Added issue to unsorted:

#1992010: Reverting to revisions prior to addition of field translations is broken Issue is 9 years old, marked as critical and has patch that is RTBC and passes automated tests. Are tests sufficient?

poker10’s picture

poker10 commented

We have approx. one month until the next planned D7 release (1.6.2022).

If it is not planned to postpone this release, hopefully @mcdruid or @Fabianx will make some time to review and commit at least most important issues (as there are few PHP 8.1 deprecations, few PostgreSQL important performance fixes and few others).

I must say that we are looking forward especially for the mentioned four PostgreSQL backport issues, as we are running a lot of PostgreSQL sites and perfomance benefits should be big (it should also help Drupal testing infrastructure as well).

Thanks!

mcdruid’s picture

mcdruid commented

Thanks for the updates to this meta issue.

My last several weeks have either been busy or disrupted, but I'll try to get some issues from the list(s) here reviewed ASAP.

The 2022-06-01 release is likely to be fairly "light" though in terms of the number of issues / fixes / commits.

poker10’s picture

poker10 commented
Issue summary: View changes

Adding one another potential candidate for this release. It is a D9 backport, so it should be a relatively easy fix. And it could help lot of people experiencing broken watchdog. Test for that usecase is included.

#2790857: Log completely unusable when an entry has corrupt serialized data (D7)

ressa’s picture

ressa
he/him
commented
Title: [meta] Priorities for 2022-06-01 release of Drupal 7 » [meta] Priorities for June 1, 2022 release of Drupal 7

Would June 1, 2022 date format in the title in stead of 2022-06-01 result in faster scannability? Feel free to revert this change, if you think it is a step backwards.

mcdruid’s picture

mcdruid commented
Title: [meta] Priorities for June 1, 2022 release of Drupal 7 » [meta] Priorities for 2022-06-01 release of Drupal 7
Issue summary: View changes

Added #3281663: D7 backport: Fix htaccess files for PHP 8.

@ressa I've switched the date in the title back. It might just be because I am a Brit who has worked in a predominantly US company for nearly a decade, but I have quite a strong preference for ISO-8601 :)

https://xkcd.com/927/

ressa’s picture

ressa
he/him
commented

That's cool, I thought I'd just float the idea :)

poker10’s picture

poker10 commented
Issue summary: View changes

Adding two another possible candidates for this/next release:

#1158322: Add backtrace to all errors - but maybe it would need some decision first

#3266018: Backport Make core aware of Nginx and PHP-FPM to D7 - simple backport

poker10’s picture

poker10 commented
Issue summary: View changes

I have quickly checked other RTBC issues and found 4 simple issues - each of them has tests, so I am adding them here to consider.

#2112325: Warning: gzinflate(): data error in drupal_serve_page_from_cache() (line 1617 of /includes/bootstrap.inc).

#3212398: [D7] Field API assumes serial/integer entity IDs, but the entity system does not - D8 backport, approved also by @Fabianx

#2828455: User mail token PHP notices for anonymous

#3166668: PHP7.4 and empty entity_keys for taxonomy term result in notices - this issue was RTBC, but a small patch update was needed according to the detailed testing

poker10’s picture

poker10 commented
Issue summary: View changes

Sorry for "spam", but this simple fix/backport was also RTBC with a patch from @David_Rothstein, but only a test was missing. I have added the test, so it should be safe to go now :)

#2594955: [D7] Duplicate HTML IDs are created for file_managed_file fields

mcdruid’s picture

mcdruid commented
Status: Active » Needs review
StatusFileSize
new 3259739-16_noop.patch285 bytes

Adding a noop patch to ensure all tests pass before preparing 7.90 (I'm not available to work on the release next week).

poker10’s picture

poker10 commented

Thanks for all your work on this release @mcdruid!

And wow, look at these numbers... PostgreSQL tests done in 8 minutes!! It was 25 minutes before (yes we also skipped 2 upgrade functions, but that can be only benefit of minute or two).

I know that probably the release is already closed but is there any chance to include the last two PHP8/8.1 issues to 7.90?

Thanks again!

mcdruid’s picture

mcdruid commented

Thank you for all the work you've put into this release @poker10!

Good to see the tests are green - PHP 5.6 initially failed but it was just testbot snafu.

Unfortunately I won't be able to get anything else into 7.90 - I need to have the release ready pretty much now and will just be doing the final few formalities next week on 2022-06-01.

Here are the draft release notes:

Release notes

Maintenance release of the Drupal 7 series. Includes bug fixes and small API/feature improvements only (no major, non-backwards-compatible new functionality).

No security fixes are included in this release.

No changes have been made to the .htaccess, web.config, robots.txt or default settings.php files in this release, so upgrading custom versions of those files is not necessary.

A change has been made to the .htaccess file that Drupal generates to prevent PHP execution in files directories. See the Change Record for more details of how to ensure your site's .htaccess files are up-to-date.

This release includes improved support for PHP 8.1 (and other recent PHP releases), but there may still be problems not revealed by Drupal core's test suite, especially on sites with contrib (and custom) modules. Please test, and report any problems in the appropriate issue queue.

This release also includes some major performance improvements for PostgreSQL. Special thanks to poker10 for providing several backports that make a significant difference.

As always, many thanks to everyone that contributed to this release of Drupal 7.

Major changes in 7.90:

All changes:

long.skinny.boy’s picture

long.skinny.boy commented

Good afternoon, thanks for the new release! Please tell me if there are plans to add a fix to this problem?

https://www.drupal.org/project/drupal/issues/3176634

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Anything not included in 7.90 should be moved into a new planning issue and this one should be marked "fixed" (by a core maintainer so that attribution can be given).

mcdruid’s picture

mcdruid commented
Status: Needs review » Fixed

@long.skinny.boy that issue is in the todo list(s) in the (newly created) meta issue for the next release #3292217: [meta] Priorities for 2022-12-07 release of Drupal 7 (which is not a guarantee it will be included I'm afraid). Feel free to advocate for it to be looked at in the comments for that issue.

Closing this as Fixed per @DamienMcKenna in #20.

Thank you everyone that contributed to 7.90!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3214921: Add a requirements warning in Drupal 9 when PostgreSQL is used and the pg_trgm extension is not created, +#3214922: Add a requirements error in Drupal 10 when PostgreSQL is used and the pg_trgm extension is not installed or created

@poker10 and @mcdruid, I have been impressed by all the fantastic work on improving the Postgresql and SQLLite db abstraction layers, recently I also noticed that adding the pg_trgm extension seemed to very much improve performance on postgres v12.10 or v12.8.

#3214921: Add a requirements warning in Drupal 9 when PostgreSQL is used and the pg_trgm extension is not created