Problem/Motivation

There's a false "composer install" command reference in GPX & geometry data submodules. Should be "composer require":

modules/geolocation_geometry/modules/geolocation_geometry_data/geolocation_geometry_data.info.yml

-description: 'Import and provide geometry data. ATTENTION: Requires "composer install gasparesganga/php-shapefile".'
+description: 'Import and provide geometry data. ATTENTION: Requires "composer require gasparesganga/php-shapefile".'

modules/geolocation_gpx/geolocation_gpx.info.yml

-description: 'GPX file field type, widget & formatter. ATTENTION: Requires "composer install sibyx/phpgpx"'
+description: 'GPX file field type, widget & formatter. ATTENTION: Requires "composer require sibyx/phpgpx"'

Issue fork geolocation-3302558

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tormi created an issue. See original summary.

tormi opened merge request !21

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
CreditAttribution: tormi for Buildig commented
Status: Active » Needs review
ressa’s picture

ressa CreditAttribution: ressa at Ardea commented
Status: Needs review » Reviewed & tested by the community

Thanks @tormi, I also just saw this, while trying out the module. Your patch fixes it, and the correct Composer commands are now shown.

Manoj Raj.R’s picture

Manoj Raj.R CreditAttribution: Manoj Raj.R as a volunteer commented

@tormi
composer require is a good catch.
Patch looks good for me.

  • 969ad900 committed on 8.x-3.x 
    Issue #3302558 by tormi: False "composer install" command reference in...

ChristianAdamski closed merge request !21

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented

There was issue with me merging automatically. So I did it manually. But the name is not showing up?

Anyway, fixed. Thanks!

ChristianAdamski’s picture

ChristianAdamski CreditAttribution: ChristianAdamski commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.