Problem/Motivation

When you select a facet value, and later that facet value is getting hidden because no results exist for that combination, we need a way to remember that value was initially selected, so it stays selected once it is relevant again.

I added a video to explain the issue, as you see, Red is not remembered.

CommentFileSizeAuthor
#5 3400585-5.patch2.86 KBStryKaizer
#3 3400585-3.patch2.19 KBStryKaizer
#2 3400585-2.patch2.49 KBStryKaizer
Demo-issue-tag-forgot.mp4184.44 KBStryKaizer
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StryKaizer created an issue. See original summary.

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Active » Needs review
FileSize
3400585-2.patch2.49 KB

This needs thorough review before going in.

Since we need to "emulate" values which are not in the option list, but we want the same form element name, we add hidden form values as text strings.

Doing this, we need to be sure we do not introduce any security issues before committing...

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
FileSize
3400585-3.patch2.19 KB

Replaced the string in favor of an actual hidden form element

malik.kotob’s picture

malik.kotob CreditAttribution: malik.kotob at Pantheon commented
Status: Needs review » Reviewed & tested by the community

Tested and worked very well!

StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Reviewed & tested by the community » Needs review
FileSize
3400585-5.patch2.86 KB

Added check to ensure we only alter views_exposed_forms for views which actually use facets exposed filters.

Status: Needs review » Needs work

The last submitted patch, 5: 3400585-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • StryKaizer committed 98be0aae on 3.0.x 
    Issue #3400585 by StryKaizer, malik.kotob: Exposed filters: remember non...
StryKaizer’s picture

StryKaizer
Primary language Dutch
Location Belgium
CreditAttribution: StryKaizer as a volunteer and at ClicketyClick commented
Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.