Problem/Motivation

Is it planned to release a D10 version of this module?

Issue fork commerce_choose_price-3362480

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aleix created an issue. See original summary.

aleix opened merge request !3

rymcveigh’s picture

rymcveigh
he/him/his
CreditAttribution: rymcveigh at Morris Animal Foundation commented
Status: Active » Reviewed & tested by the community

These changes look good to me, though I wonder if we should still support drupal version 8.x?

lkacenja’s picture

lkacenja
he/him
CreditAttribution: lkacenja at Morris Animal Foundation commented

Since Drupal 8 was EOL November 17, 2021, in my opinion it feels ok to drop support there. I am not honestly sure if the module would still work with that codebase or not.

aleix’s picture

aleix CreditAttribution: aleix at Communia commented

I have it working with D10. If you need something to be checked more in depth I could test asap.

rymcveigh’s picture

rymcveigh
he/him/his
CreditAttribution: rymcveigh at Morris Animal Foundation commented
Status: Reviewed & tested by the community » Needs work

I'm putting this into needs work because we should remove the ^8 from the ^8 || ^9 || ^10. I can adjust the MR.

rymcveigh’s picture

rymcveigh
he/him/his
CreditAttribution: rymcveigh at Morris Animal Foundation commented
Status: Needs work » Needs review

Okay, I removed 8.0 from the changes and returned it to needs review.

lkacenja’s picture

lkacenja
he/him
CreditAttribution: lkacenja at Morris Animal Foundation commented
Status: Needs review » Reviewed & tested by the community

This looks good to me. Thanks @rymcveigh.

lkacenja’s picture

lkacenja
he/him
CreditAttribution: lkacenja at Morris Animal Foundation commented
lkacenja’s picture

lkacenja
he/him
CreditAttribution: lkacenja at Morris Animal Foundation commented
Status: Reviewed & tested by the community » Fixed

Forgot to close. Sorry for the chatter.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.