Problem/Motivation

In the interest of minimizing maintenance surface area within the module, integration for various themes, icon sets, and plugins that are infrequently used and largely unmaintained to date. If demand is heard for any of these to be re-added, a method may be explored for the editor to be cleanly hooked into to customize options and add related libraries.

Steps to reproduce

Settings changes
  • Navigate to Patternkit JSON Library Settings (/admin/config/user-interface/patternkit/json)
  • Theme selection should no longer be available
  • Icon set options should no longer include removed options
  • WYISWYG options should only list CKEditor5 if the CKEditor5 module is available
Database updates
  • Database updates should run to...
    • Default the theme to Cygnet if a removed theme was in use
    • Remove icon set selection if a removed set was in use
    • Remove WYSIWYG selection if a removed option was in use
Maintained functionality
  • Create a new Patternkit Example block in an overridden node layout
  • The editor form should be styled using the Cygnet theme
  • HTML fields should use the selected WYSIWYG editor if any

Proposed resolution

  • Remove unsupported icon sets per the JSONEditor list of supported icons:
    • bootstrap2
    • bootstrap3
    • foundation2
    • foundation3
  • Remove no longer supported/maintained JSONEditor themes:
    • jqueryui
    • bootstrap2
    • bootstrap3
    • bootstrap4
    • foundation3
    • foundation4
    • foundation5
    • foundation6
  • Hide the theme selection input
  • Remove no longer supported WYSIWYG options:
    • CKEditor4
    • Quill
    • ProseMirror

Remaining tasks

User interface changes

  • Unsupported JSONEditor themes are removed as options
  • JSONEditor theme selection input is hidden
  • Unsupported JSONEditor icon sets are removed as options
  • Unsupported JSONEditor WYSIWYG options are removed as options

API changes

None

Data model changes

None

CommentFileSizeAuthor
#4 DAT 5233_Retest.odt465.94 KBminsharm

Issue fork patternkit-3419540

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

slucero created an issue. See original summary.

slucero’s picture

Status: Active » Needs review
minsharm’s picture

FileSize
465.94 KB

Retested the results of the recent changes in the Patternkit JSON Library Settings and result looks good to me.

Steps to Test :

Navigate to Patternkit JSON Library Settings (/admin/config/user-interface/patternkit/json)

Results :

  • Theme selection is no longer available, and unsupported themes have been successfully removed.
  • Several unsupported icon options have also been removed.
  • WYSIWYG options now list CKEditor5 only if the CKEditor5 module is available.
slucero’s picture

Status: Needs review » Fixed

Merged for inclusion in the Beta 9 release.

  • slucero committed 9074c185 on 9.1.x
    Issue #3419540 by slucero, minsharm: Remove Unsupported JSONEditor...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.