Currently, access control for a role is automatically enabled when the user visits admin/config/people/taxonomy_access/role/%/edit
. Instead, we should make this an independent operation, and provide the link to enable or disable at the top of admin/config/people/taxonomy_access/role/%/edit
. If the role is enabled, the disable link should be at the top; if the role is disabled, they should see only the enable link and possibly some help text.
As part of this change, the enable/disable links on admin/config/people/taxonomy_access
should be removed, and the "edit" link there should be changed to "configure."
Comment | File | Size | Author |
---|---|---|---|
#5 | role_config.patch | 83.26 KB | xjm |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedHere's a quick pass at what a simple API function for enabling a role could look like:
Comment #2
xjmI realized that I actually have to rework the entire admin form in order to implement this (and part of it may predate FAPI...) So it will take a little more time, and not a novice issue.
Comment #3
xjmThe API function has been added in http://drupal.org/commitlog/commit/364/564c515cd32825fc8a27245be2c9bbaa6..., but I ended up rolling back the user-facing part of the change because it was just too messy. The form theming is likely due to be modernized anyway.
Comment #4
xjmBroadening the scope here because I have to change half the form anyway to do this. Dratted legacy code.
hook_update_N()
to insert a vocab. default matching the global default for vocabs with term records in{taxonomy_access_term}
.Comment #5
xjmAlright, lest perfect persist in being the enemy of the good, here's the patch from the role_config branch as it's been for the past month or so. There's a few outstanding improvements I'd like to make and test coverage I'd like to add, but I'll likely spin those things off as followup issues. The patch is fully functional.
Comment #6
xjmComment #7
xjmCouple quick code style notes:
This line has been removed from the menu callback standard, and should be stripped.
Could use an actual summary.
Comment #8
xjmhttp://drupal.org/commitlog/commit/364/6049a1f7d68df1f0378f2e4322a83c6cd...
Followup issues to follow.
Comment #9.0
(not verified) CreditAttribution: commentedUpdated issue summary.