Re-add taxonomy_term_count_nodes()

http://drupal.org/project/term_node_count
This project has views integration etc etc :)

Although a CCK Count module would be cool where we can select the table, or the column for which we want to maintain a summary table :)

The proper way to fix this would be #603236: Add count facility to field_attach_query(). There's not much time before freeze but let's explore that before we revert here - whether it's a contrib helper module or a core patch.

Between #603236: Add count facility to field_attach_query() and http://drupal.org/project/term_node_count there's an ability to get the count in core, and a module implementing what looks to be a nice performant lookup table in contrib (and which should be able to use field hook and field_attach_query() to do what it's doing in D6). So marking this as a duplicate of those two.

I also opened #603868: Rework Term Node Count for D7.

Hi everyone!
It's my first comment at drupal.org and my first "drupal-custom-functioning" experience.
I wrote a simplest function to count nodes by term ID.

Hope someone find it useful.

<?php
/*
 * @param tid
 *   Term ID
 * @param child_count
 *   TRUE - Also count all nodes in child terms (if they exists) - Default
 *   FALSE - Count only nodes related to Term ID
 */
function term_nc($tid, $child_count = TRUE) {
  $tids = array($tid);
  
  if ($child_count){
  $children = taxonomy_get_children($tid);
    if (!empty($children)){
      foreach($children as $child){
        $tids[] = $child->tid;
      }
    }
  }
  
  $tids = implode(" OR tid = ", $tids );
  $sql = "SELECT COUNT(nid) FROM {taxonomy_index} WHERE tid = $tids";
  $count = db_query($sql)->fetchField();
  return  $count;
}
?>

An improvement of #5, with some recursion to take account of hierarchical children.

/*
 * @param tid
 *   Term ID
 * @param child_count
 *   TRUE - Also count all nodes in child terms (if they exists) - Default
 *   FALSE - Count only nodes related to Term ID
 */
function term_nc($tid, $child_count = TRUE) {
  $tids = array($tid);
  
  if ($child_count){
    term_get_children_ids($tid, &$tids)
  }
  
  $tids = implode(" OR tid = ", $tids );
  $sql = "SELECT COUNT(nid) FROM {taxonomy_index} WHERE tid = $tids";
  $count = db_query($sql)->fetchField();
  return  $count;
}

/**
 * Retrieve ids of term children .
 *
 * @param $tid
 *   The term's ID.
 * @param $tids
 *   An array where ids of term children will be added
 */
function term_get_children_ids($tid, &$tids) {
  $children = taxonomy_get_children($tid);
  if (!empty($children))
  {
    foreach($children as $child)
    {
      $tids[] = $child->tid;
      term_get_children_ids($child->tid, $tids);
    }
  }
}

Some tweaks on #6:

1) Modified the handling of the recursive sub-function. I was getting "call_time_pass_reference" errors.

2) Added language criteria. Only nodes in the current language and neutral language (undefined) are counted.

Note: I'm not a programmer. I go around copying, pasting and tweaking others' codes. So, use cautiously. Any improvements are wellcome.

/*
* @param tid
*   Term ID
* @param child_count
*   TRUE - Also count all nodes in child terms (if they exists) - Default
*   FALSE - Count only nodes related to Term ID
*/
function term_nc($tid, $child_count = TRUE) {
  $tids = array($tid);
 
  if ($child_count){
    $tids = array_merge($tids, term_get_children_ids($tid));
  }
  
  global $language;
  $langs = array($language->language);
  $langs[] = 'und';
  
  
  $query = db_select('taxonomy_index', 't');
  $query->condition('tid', $tids, 'IN');
    $query->join('node', 'n', 't.nid = n.nid');
    $query->condition('n.status', 1, '=');
    $query->condition('n.language', $langs, 'IN');

$count = $query->countQuery()->execute()->fetchField();
  return  $count;
}

/**
* Retrieve ids of term children .
*
* @param $tid
*   The term's ID.
* @param $tids
*   An array where ids of term children will be added
*/
function term_get_children_ids($tid) {
  $children = taxonomy_get_children($tid);
  $tids=array();

  if (!empty($children))
  {
    foreach($children as $child)
    {
      $tids[] = $child->tid;
      $tids = array_merge($tids, term_get_children_ids($child->tid));
    }
  }
 
return $tids;
}
?>

Thanks!!