Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
What the title says. Going to extract from #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest.
Comment | File | Size | Author |
---|---|---|---|
#20 | use-entity-test-2004224-20.patch | 101.85 KB | Berdir |
#13 | use-entity-test-2004224-13.patch | 101.85 KB | Berdir |
#13 | use-entity-test-2004224-13-interdiff.txt | 4.37 KB | Berdir |
#9 | interdiff.txt | 1.33 KB | andypost |
#9 | use-entity-test-2004224-9.patch | 103.78 KB | andypost |
Comments
Comment #1
BerdirFirst extract, let's see if I got everything I need.
Comment #3
BerdirThis should fix those tests.
Comment #5
Berdir#3: use-entity-test-2004224-3.patch queued for re-testing.
Comment #7
andypostComment #8
andypostre-roll with small changes
Comment #9
andypostproper merge
Comment #10
andypostDrupal\field\Tests\FormTest
still broken, @Berdir I cant fix thatComment #11
BerdirYeah, that's because the method that I changed is also used there and it's used with the old entity type that's not yet NG.
One possible way to fix this would be to keep and override of that method in FormTest, with a @todo to kill it when no longer necessary.
Comment #13
BerdirSomething like this. Also removing the EntityTestCache class, I don't think we need this one here.
Comment #14
andypostSo now it works!
Comment #15
BerdirThis is part of a critical issue and blocking the @yched's field api/typed data issue, so raising to major to give it some visibility.
Comment #16
swentel CreditAttribution: swentel commentedThis is almost critical imo, because we need #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest after that and then we can (finally) start on #1953408: Remove ArrayAccess BC layer from field config entities (which is also critical).
Comment #17
Berdir#13: use-entity-test-2004224-13.patch queued for re-testing.
Comment #18
alexpottNeeds a reroll
Comment #19
alexpottComment #20
BerdirHere it is.
Comment #21
BerdirStarting to use that tag for things we need to do to complete conversion, remove BC layer and fully convert field API to Entity Field API/Typed data.
Comment #22
yched CreditAttribution: yched commentedGreen, back to RTBC ?
Comment #23
BerdirRe-adding tag.
Comment #24
swentel CreditAttribution: swentel commentedComment #25
yched CreditAttribution: yched commentedYeah, meant to do that in #22, but instead I removed the tag :-D Sorry folks.
Let's get this in !
Comment #26
yched CreditAttribution: yched commentedBump.
Getting this in would help #1969728: Implement Field API "field types" as TypedData Plugins :-)
Comment #27
yched CreditAttribution: yched commented#20: use-entity-test-2004224-20.patch queued for re-testing.
Comment #28
alexpottCommitted bf2c404 and pushed to 8.x. Thanks!
Comment #29
BerdirRemoving sprint tag. The saga continues in #1822000: Remove Drupal\field_test\Plugin\Entity\Type\TestEntity in favor of EntityTest.