Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Not sure the base reason, but it doesn't sound right to create an translation_entity_access_check instead of entity_translation_access_check.
Comment | File | Size | Author |
---|---|---|---|
#36 | 2024867-rename-translation_entity-36.patch | 173.94 KB | vijaycs85 |
#33 | 2024867-rename-translation_entity-33.patch | 167.61 KB | vijaycs85 |
#31 | 2024867-rename-translation_entity-31.patch | 173.54 KB | vijaycs85 |
#31 | 2024867-diff-28-31.txt | 980 bytes | vijaycs85 |
#28 | 2024867-rename-translation_entity-28.patch | 172.58 KB | vijaycs85 |
Comments
Comment #1
vijaycs85Initial patch...
Comment #3
vijaycs85Seems we got an issue for this at #1985488: Consider renaming translation_entity module and it is blocked by #1952062: Remove legacy translation module in favor of content translation
Comment #4
vijaycs85Renaming files.
Comment #5
Gábor HojtsyComment #6
plachThanks for working on this but I think we should avoid the entity_translation namespace, since it would prevent us from being able to provide a proper upgrade path from D7 ET to D8 in contrib. What about content_translation instead? It would be consistent with config_translation.
Comment #7
vijaycs85yep, content_translation makes more sense...
Comment #8
vijaycs85Comment #10
plach#7: 2024867-rename-translation_entity-7.patch queued for re-testing.
Comment #11
vijaycs85Updating labels and seems missed to remove few files...
Comment #12
vijaycs85BTW, tests are green locally!
Comment #13
plachAwesome! Just some minor stuff and we should be good to go :)
We need to update the behavior namespace here.
I'd say it was missing an article but I'd keep the uppercase letters:
The correct url currently is https://drupal.org/documentation/modules/translation_entity. It will change again probably.
a content translation
Comment #14
plachWe'll need to rename the component too. Gabor, will you? ;)
Comment #15
vijaycs85Thanks for the review @plach. Here is my update:
For #13:
Comment #17
plach#15: 2024867-rename-translation_entity-15.patch queued for re-testing.
Comment #19
plach#15: 2024867-rename-translation_entity-15.patch queued for re-testing.
Comment #21
plach#15: 2024867-rename-translation_entity-15.patch queued for re-testing.
Comment #22
vijaycs85FYI - Seems locally all these failing test cases are fine :)
Comment #23
plachQED :)
Comment #24
jibranThis is not a bug at all.
Comment #25
plachThe main reason for renaming ET is #1985488: Consider renaming translation_entity module, which is actually a bug.
However I agree this is a task :)
Comment #26
Gábor HojtsyIf we want to have this land first, then it should have Avoid commit conflicts.
Comment #27
Gábor Hojtsy@alexpott points out there are unrelated changes in the patch that are not involved with the rename. Eg. phpdoc type documentation changes. Those should not be coupled in, making it easier to review and get committed.
Comment #28
vijaycs85Removing changes that are not related to this issue.
Comment #29
Gábor HojtsyLet's get this in then! Thanks for rolling it this way :)
Comment #30
alexpottFrom MenuFormController::actions()
Need to update...
Comment #31
vijaycs85Not sure how did I miss it....
Comment #32
alexpottNeeds a reroll cause #1969728: Implement Field API "field types" as TypedData Plugins has landed...
Comment #33
vijaycs85Re-rolling...
Comment #34
Gábor HojtsyHow did this become 5k smaller vs. the prior patch?
Comment #36
vijaycs85somehow, can't re-roll after that patch.. had to re-do all again. hope this is the closer one, but needs full review again :(
Comment #37
Gábor HojtsyI spot-checked and it looked good. Should be up for @alexpott again if/when green :)
Comment #38
alexpottCommitted de3558c and pushed to 8.x. Thanks!
Comment #39
alexpottRemoving tag
Comment #40
Gábor HojtsyThis was also added to the "original" change notice for the introduction of the module (introduction happened in November 2012, I just wrote the change notice). See https://drupal.org/node/2028009
Comment #41
Gábor HojtsyComment #43
Gábor HojtsyRemove from sprint!