First, I have to say this is by far the best select widget that I have used. Thank you for all of your hard work.

I have a select field that allows unlimited values and Chosen configured to auto apply on all multi-select fields. When the field has "Unlimited" values set, the field shows no options to choose from when clicking in the field.

However, on that same field, the moment I set it to 10 values, it works without problems.

Thanks in advance for any help.

CommentFileSizeAuthor
#8 multi-select-unlim-2079255.patch2.14 KBazovsky
#5 chosen-unlimited-cardinality-2079255-5.patch1.4 KBjdidelet
#4 chosen-missing-test-multiple-property-2079255-4.patch550 bytesjdidelet

Comments

nwom’s picture

nwom commented

I also get the following error message on the node add page. Maybe it has something to do with the same problem:

Notice: Undefined index: #multiple in chosen_pre_render_select() (line 182 of C:\inetpub\wwwroot\sites\all\modules\chosen\chosen.module).

patrickroma’s picture

patrickroma commented

Same here...

patrickroma’s picture

patrickroma commented

Same here...

jdidelet’s picture

jdidelet commented
Status: Active » Needs review
StatusFileSize
new chosen-missing-test-multiple-property-2079255-4.patch550 bytes

patch attached for error related to #multiple

jdidelet’s picture

jdidelet commented
StatusFileSize
new chosen-unlimited-cardinality-2079255-5.patch1.4 KB

attached new patch who resolve both problems.

hydra’s picture

hydra commented
Status: Needs review » Fixed

Well I'm not very happy with this solution. In the near future there will be a whole lot of configurable options introduced by #2076813: Move library options (configuration) to library plugin.
Anyway, till this is going to happen, I'm happy with this quickfix. Thanks for sharing the patch!
Pushed to 7.x-2.x http://drupalcode.org/project/chosen.git/commit/5ff10ed

jdidelet’s picture

jdidelet commented

Ah yes sorry. I probably didn't do in the most efficient way because I'm not aware of all of this for chosen module. It was just a quick patch to resolve this blocking point because I myself use this module for my projects. Anyway, thanks for your work on this module. I'll try to be more careful next time I'll submit a patch (or just mention it's a quick dirty patch :)).

azovsky’s picture

azovsky commented
Status: Fixed » Needs review
StatusFileSize
new multi-select-unlim-2079255.patch2.14 KB

Fix from #5 breaks work of multi-selection (ability to select only one item) if on the page has other chosen fields.
So, here's my attempt to fix it in the patch.

nwom’s picture

nwom commented

Like what azvosky said, the fix then broke my Organic Groups audience widget. After applying fix #8 on top of the already committed patch, both problems have now been fixed. Thank you very much jdidelet and azovsky!

attiks’s picture

attiks commented
Priority: Major » Critical
Status: Needs review » Reviewed & tested by the community

Thanks, bumping to critical

hydra’s picture

hydra commented

Thanks for the fix azovsky and thanks for the review attiks! Pushed to 7.x-2.x http://drupalcode.org/project/chosen.git/commit/d431aa2

hydra’s picture

hydra commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Typos corrected