Updated: Comment #0

Problem/Motivation

#2105661: Add support for $form_state['redirect_route'] added new route-based form redirects. That issue did only one example conversion.

Proposed resolution

Convert as many as possible.

Remaining tasks

Decide what to do with ones that are not easy to convert

User interface changes

N/A

API changes

N/A

CommentFileSizeAuthor
#14 redirect-2125253-14.patch110.08 KBtim.plunkett
#14 interdiff.txt727 bytestim.plunkett
#12 form-2125253-5.patch110.53 KBtim.plunkett
#8 interdiff.txt1.2 KBtim.plunkett
#8 form-2125253-4.patch110.53 KBtim.plunkett
#6 form-2125253-3.patch110.29 KBtim.plunkett
#3 interdiff.txt16.02 KBtim.plunkett
#3 form-2125253-2.patch67.44 KBtim.plunkett
#1 form-2125253-1.patch53.1 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new form-2125253-1.patch53.1 KB

This is just the first couple modules, and because I wanted to try new-d.o :)

Status: Needs review » Needs work

The last submitted patch, 1: form-2125253-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new form-2125253-2.patch67.44 KB
new interdiff.txt16.02 KB

Fixed the failures, and did some more conversions.

In #2052325: Move search block form to new drupal 8 standard, search_box() was removed. But through a bad reroll, it was accidentally reintroduced as dead code in #2003482: Convert hook_search_info to plugin system. I only noticed because I was converting the same redirect twice.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review

And so it begins

Status: Needs review » Needs work

The last submitted patch, 3: form-2125253-2.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form-2125253-3.patch110.29 KB

As I said in #1987802: Convert path_admin_overview() to a new style controller comment #82, path module's submit functions are currently broken, so I'm not going to silently fix them here.

Until #1810350: Remove menu_* entity keys and replace them with entity links happens, this is about as far as this issue can go.

Status: Needs review » Needs work

The last submitted patch, 6: form-2125253-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new form-2125253-4.patch110.53 KB
new interdiff.txt1.2 KB

Typo for custom block, and fun bug for the language one.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Let's get that in while it is hot.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

8: form-2125253-4.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 8: form-2125253-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new form-2125253-5.patch110.53 KB

Small patch conflict in core/modules/node/lib/Drupal/node/Form/NodeDeleteForm.php, nothing big, no changes.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Patch no longer applies

git ac https://drupal.org/files/issues/form-2125253-5.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  110k  100  110k    0     0  48891      0  0:00:02  0:00:02 --:--:-- 53013
error: core/modules/system/lib/Drupal/system/Form/DateFormatLocalizeResetForm.php: does not exist in index
error: patch failed: core/modules/system/system.admin.inc:860
error: core/modules/system/system.admin.inc: patch does not apply
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new interdiff.txt727 bytes
new redirect-2125253-14.patch110.08 KB

The hunk that didn't apply was removed from core.
In the meantime, a new form was added, converted that.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Getting this one in while it's hot! :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.