Remove drupal_set_title in Image module controllers

Looks good and I test it manually. Thank you!

Lets add a test as we don't test this title anywhere

Actually that'd add the possibility of random fails due to the label contain < or > so let's use random name here instead.

+++ b/core/modules/image/lib/Drupal/image/Tests/ImageAdminStylesTest.php
@@ -189,7 +189,8 @@ function testStyle() {
+    $this->assertResponse(200, format_string('Image style %original renamed to %new', array('%original' => $style->id(), '%new' => $style_name)));

String::format()?

Theoretically it would be enough to use a _title_callback as you can pull somehow the upcasted entity from there.

Out of scope (I think) I was was just resolving the confusion between id and label that the original message had - which I believe was in scope as it caused me to write an incorrect title assertion the first time around.

My comment in #7 about out-of-scope refers to #5 not @dawehner's comment.

Sorry, I think I'm missing something, or... Why not intentionally testing with "<" or ">" or even unsafe names? The new "set title" (in fact $this->t()) should sanitize the value, no? And format_string() does the same. So we should end every time with a true assertion.

I'm OK with the initial patch, that's why I'd RTBC it. #9 was a proposal for a better test.

So, yes, RTBC again :)

#4: remove_drupal_set_title_in_image_module-2102459-4.patch queued for re-testing.

Committed to 8.x.

How do I mark this 'fixed'? It looks like the 7.x upgrade degraded the contributor experience on drupal.org. :-/

#2128721: No follow button is a recent regression, fwiw, but there is much contributor feedback about the experience that is being gathered with the D.o UX tag.

Edit: both the Follow and the "Update this issue" link have gone missing.