[D7] embAd

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxramsegal1893214git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

in the .info file, probably you could add in the embad_uninstall() function :

global $conf;
if  ( isset($conf['embad_pid']) ) {
  variable_del('embad_pid');
}

also there is a little typo in the .admin.inc file :

form_set_error('embad_pid', t('You must enter a number for "Pulisher ID".'));

that should be

form_set_error('embad_pid', t('You must enter a number for "Publisher ID".'));

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

I'm a robot and this is an automated message from Project Applications Scraper.

Can you please wrap your lines?
embad.module
line 48, length 114
line 49, length 133

From https://drupal.org/coding-standards#linelength:
In general, all lines of code should not be longer than 80 chars.

It just makes it easier to see the code.

For embad.install:
"If you need to define global variables, their name should start with a single underscore followed by the module/theme name and another underscore." as found in https://drupal.org/coding-standards

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

Code too short

This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project for you.

• The technique in embad_uninstall() is interesting, but if you already know the variables you want to delete, just list them out. For ex: variable_del('embad_pid '); variable_del('embad_status'); variable_del('embad_wsid'); ...
• You also don't need to set a default value in hook_install(), just provide the correct default when you read the variable.

Looks like a decent module, just not enough to grant 'git vetted user' status. We're more than happy to promote this project individually though!

----
Top Shelf Modules - Crafted, Curated, Contributed.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.