Drupal core already include http://benalman.com/projects/jquery-bbq-plugin into 7.x by default with MIT/GPL dual license.

On the other hand, my new project twbs_jquery.make would like to download it from official site with latest version manually.

May someone give a hand for adding the following Regex into whitelist?

^https://github\.com/cowboy/jquery-bbq/.+$

P.S. The ^https://github\.com/hswong3i/jquery-bbq/.+$ is a patched version for jQuery 1.9+

Comments

kreynen’s picture

kreynen commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Confirming that all the code in the https://github.com/cowboy/jquery-bbq/ repo is MIT/GPLv2 and the download is 2.3MB.

After removing the https://github.com/hswong3i/jquery-bbq fork from the original request I consider this RBTC. Rather than approving multiple forks of the same code on Github, I think we should only approve the official repo ask the distribution developer to do any additional patching in their .make file. That makes it much more obvious that the specific distribution is using a modified version of a library and keep the job of reviewing the whitelist requests much more manageable.

hswong3i’s picture

hswong3i commented

Understand the recommendation and so a meta issue #2138761: [meta][jquery-bbq] Remove legacy browser support for jQuery >= 1.9. created for our own needs, and twbs_jquery.make updated as below:

libraries[jquery-bbq][directory_name] = jquery-bbq
libraries[jquery-bbq][download][type] = file
libraries[jquery-bbq][download][url] = https://github.com/cowboy/jquery-bbq/archive/master.zip
libraries[jquery-bbq][patch][2138761] = https://drupal.org/files/issues/twbs_jquery-bbq_no_legacy_ie-2138761-1.patch
libraries[jquery-bbq][type] = library

P.S. Just would also like to highlight that jquery-bbq haven't been updated since 3 years ago (https://github.com/cowboy/jquery-bbq/commits/master), where numbers of pull request send out for this jQuery >= 1.9 issues (https://github.com/cowboy/jquery-bbq/pulls). Therefore I don't really think that reporting that to original author can get help about solving it "officially" ;-S

btopro’s picture

btopro commented

I think the concern is more so the idea of constantly supporting packaging of forks from different projects.

hswong3i’s picture

hswong3i commented

As refer to #1, shall we just keep it simple stupid as below:

^https://github\.com/cowboy/jquery-bbq/.+$

Where individual needs can handle as like as #2 solution?

btopro’s picture

btopro commented

Looks good to me; will let kreynen push forward since he had the original reservations til the previous comment was verified.

kreynen’s picture

kreynen commented
Status: Reviewed & tested by the community » Fixed

https://drupal.org/node/2140359

hswong3i’s picture

hswong3i commented

Thank you for prompt reply and update ;-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.