[D7] Userreference Realname

Hi chunglk,

Very nice work.
Few questions and comments:
1. If it a similar project to Realname Userreference but for Drupal 7, why didn't you join Realname Userreference and made the updates there? It seems like an active project with nice number of active installations.
2. The are a large number of issues at the automated test: http://ventral.org/pareview/httpgitdrupalorgsandboxchunglk1805108git
3. You are working on master branch rather than on 7.x-1.x. See http://drupal.org/node/1659588 for more informations.
4. Do you have a working example of it?

Moshe

Hi,

I understand that your module is a port of http://drupal.org/project/realname_userreference which is only available for d6, and the maintainers told he will not port it to d7.

You said on "Realname support in user-reference for D7?" http://drupal.org/node/1234656, that you did the port. Great.

Now, some questions to help you make it Full project :

1) Do you know that http://drupal.org/project/entityreference will replace soon http://drupal.org/project/references which may be considered as deprecated as indicated on the references project page. Did you thought about refactoring your module to work with entityreference?

2) We get so many errors in http://ventral.org/pareview/httpgitdrupalorgsandboxchunglk1805108git, that I have to wait to go on a manual review.
Did you use code_review from coder module ? http://drupal.org/project/coder
When do you plan to clean your code in order to follow the coding standards?

Subscribe

Would be really great to get this fixxed, If I can help let me know!

It seems you are not creating a new widget but you overwrite the ajax function of the standard one.
This means that all entity reference user fields using the autocomplete widget will have to use the realname
In that case, why not adding a setting in the widget form allowing to choose between "raw name" or "real name" when the target is a user.

subscribe

Welcome chunglk and thanks for contributing!

Automatic review:
1. There are still quite some errors to fix http://ventral.org/pareview/httpgitdrupalorgsandboxchunglk1805108git
This is not a blocker issue but will improve the speed and quality of the reviews as the code will be more readable.

Manual review
2. You are working on the master branch, you should be working on a 7.x branch and delete master.
See more info here: http://drupal.org/empty-git-master

3. Please complete the project page with useful information. Not all Drupal users known the Realname Userreference module so explain what your module does, and also what make your module different from other existing modules. This should help drupal users to decide if your module fits their needs. Screenshots are also advised. Please read again this: http://drupal.org/node/997024

4. Line 13 module file: Why return an empty t("") string ? why don't just return; ?

5. Line 81 module file: Why don't use the drupal function check_plain() instead of the preg_replace ?

Beside those issues the module works as expected.

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

If you reopen this please keep in mind that we are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Hmm, why is this closed? The maintainer has updated the code as per the feedback.

Status ought to be Needs Work.. PARreview shows some code cleanup is still needed. A bunch of tab indents instead of double-spaces, especially.

@chunglk: Any plans on working on the issues. Since you are the maintainer of the module but we don't see any activity from you from a long time.

Lets us know in case you still plan to work on this. Else we can change the status to *Closed*

@klausi: any feedback here.

Project page

Please take a moment to make your project page follow tips for a great project page.

README.txt

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

How is this module different from https://drupal.org/project/realname_userreference? If it's just D6 vs D7, could you apply to be a co-maintainer and commit this as the D7 branch?

You can remove the version string from the info file, Drupal will add it for you. Otherwise this module look fine.

----
Top Shelf Modules - Crafted, Curated, Contributed.

kscheirer: this module is the mirror complement to realname_userreference; that works on display, this works on the widget. One of those days when I don't read before posting ;) Sorry. I don't know where the maintainer is for this module; I've asked for comaint but no response yet. Making this a branch of that is certainly possible -- I'll pursue that with those maintainers now.

The pareview provides the following warnings, which may be fixed.

FILE: /var/www/drupal-7-pareview/pareview_temp/userreference_realname.module
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 2 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
45 | WARNING | Unused variable $instance.
120 | WARNING | Unused variable $widget.
--------------------------------------------------------------------------------

Hi, I'm the maintainer of http://drupal.org/project/realname_userreference

We are in the final step of choosing a partner to migrate our website to D7. I can't tell now if this module will be ported to D7 or if we will take an entirely different approach. I should have some news in february. If we still use this module on D7 I'll open a D7 branch and maintain it myself.

But anyways, if someone wants to step-up as a co-maintainer for the 7-x branch, I'd happily review the applications.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.