[D7] VisualScience

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxadammitchell2126989git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

This files don't belong to module:
devQScience.sublime-project
devQScience.sublime-workspace
Configure git to ignore those.

Implementation of hook_uninstall() shouldn't contain code to remove "Database tables defined by hook_schema() will be removed automatically."

/**
 * Form to upload a file to VisualScience.
 * 
 * @param form $form       
 *   Drupal-generated.
 * @param form-state $form_state 
 *   Drupal-generated.
 * 
 * @return string             
 *   HTML with form to be printed.
 */
function visualscience_upload_form($form, &$form_state) {
  $upload = new VisualscienceUpload();
  return $upload->visualscienceUploadForm($form, $form_state);
}

Such comments is useless and wrong. Form builder functions shouldn't describe arguments in case those are $form and $form_state only. If you form builder function takes additional parameters then you should describe all of them. There is no type 'form' in parameters types. You should read documentation for detailed description. Also return of form builder is no 'string', it is $form array.

I didn't check further. I think you already had a quite a lot of things to fix and improve.

In addition - submitting form on visualscience/upload page leads to Fatal error: Call to undefined function visualscienceUploadSubmit(). Also this form should display some instructions to user.

Just a little code review.

• Predefine $items in your hook_menu to avoid notices.
• Your project application description is missing git clone link.
• Your files must not have execution rights.
• You shouldn't have two readmes.

I did put needs work only because of the execution rights, other issues are small.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.