[D7] MediaCore Chooser

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxmediacore1708680git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Anything in needs work is not major.

Master Branch

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

• You README should have a max width of 80 chars per line.
• You can remove the .gitignore file from the repo.
• Remove the empty _mediacorechooser_settings().
• Your docblocks are wrong, _mediacorechooser_process() is not an implementation of hook_process(). Neither is mediacorechooser_admin_validate(). Only use the "implements hook_foo()." docblock when there really is a hook_foo defined in Drupal. Otherwise document the function normally.
• Don't include mediacorechoosersigning.php in the global scope - this just means it will be loaded on every Drupal page request. Only load it where it is needed.

Otherwise looks like a nice module!

----
Top Shelf Modules - Crafted, Curated, Contributed.

I hope you do know Drupal is open source and what the idea behind that is? That's why I would recommend to add comments and make it clear what is happening.

Question #8 in the FAQ on this site has a good point: "However, if your module is of general use then it is often a good idea to contribute it back to the community anyway. You can get feedback, bug reports, and new feature patches from others who find it useful."

Anyway:

• http://pareview.sh/pareview/httpgitdrupalorgsandboxmediacore1708680git is still giving some warnings
• You added defaults to your variable_get's but it could be better to add the correct defaults. E.g:
  '#default_value' => variable_get('mediacorechooser_enable_signing', 0) It would be better to use FALSE instead of 0. And with '#default_value' => variable_get('mediacorechooser_key_id', NULL), it could be better to use '' instead of NULL because it expects a string. Same for the other variable_gets

If you do want this module to be released ASAP I do recommend you to review other projects to get a review bonus. Please read: https://drupal.org/node/1975228

We can also promote this project immediately if you're not interested in getting "git vetted user" status. You can always apply for that later when you have more time.

The issues raised don't look like blockers, just suggestions for improvement.

It is done!

I looked through the module and these are my only minor suggestions:

• Single quotes are preferred when there's no variable substitution going on.
• mediacorechooser_key_id should be szie 11 as well, there's no point in offering more room if the maxlength is 11.
• mediacorechooser_secret_key should have a maxlength of 128?
• You should try to keep HTML out of t() strings, like in _mediacorechooser_tips().

----
Top Shelf Modules - Crafted, Curated, Contributed.